Author Topic: [1.7.1] Small error in functions.php  (Read 33920 times)

0 Members and 1 Guest are viewing this topic.

Offline Scout

  • Pre-Newbie
  • Posts: 3
    • View Profile
[1.7.1] Small error in functions.php
« on: March 26, 2005, 02:02:05 PM »
I found a small error in functions.php on line 64:
Code: [Select]
function check_local_thumb($remote_thumb_file) {
  return !is_remote($local_thumb_file) && strpos($local_thumb_file, '/') !== false && preg_match("#\.[gif|jpg|jpeg|png]+$#i", $local_thumb_file) ? 1 : 0;
}
I suppose that function definition should look like
Code: [Select]
function check_local_thumb($local_thumb_file) {
« Last Edit: November 13, 2005, 04:16:14 PM by Nicky »

Offline V@no

  • If you don't tell me what to do, I won't tell you where you should go :)
  • Administrator
  • 4images Guru
  • *****
  • Posts: 17.849
  • mmm PHP...
    • View Profile
    • 4images MODs Demo
Re: Small error in functions.php
« Reply #1 on: March 26, 2005, 08:26:37 PM »
thank you!
Your first three "must do" before you ask a question:
Please do not PM me asking for help unless you've been specifically asked to do so. Such PMs will be deleted without answer. (forum rule #6)
Extension for Firefox/Thunderbird: Master Password+    Back/Forward History Tweaks (restartless)    Cookies Manager+    Fit Images (restartless for Thunderbird)

Offline michi-w.

  • Hero Member
  • *****
  • Posts: 505
    • View Profile
Re: [1.7.1] Small error in functions.php
« Reply #2 on: April 25, 2005, 01:46:30 AM »
Is the bugfix also 1.7?

Gruß
michi-w.

Offline V@no

  • If you don't tell me what to do, I won't tell you where you should go :)
  • Administrator
  • 4images Guru
  • *****
  • Posts: 17.849
  • mmm PHP...
    • View Profile
    • 4images MODs Demo
Re: [1.7.1] Small error in functions.php
« Reply #3 on: April 25, 2005, 02:09:06 AM »
no
Your first three "must do" before you ask a question:
Please do not PM me asking for help unless you've been specifically asked to do so. Such PMs will be deleted without answer. (forum rule #6)
Extension for Firefox/Thunderbird: Master Password+    Back/Forward History Tweaks (restartless)    Cookies Manager+    Fit Images (restartless for Thunderbird)

Offline Filip3rd

  • Newbie
  • *
  • Posts: 25
    • View Profile
Re: [1.7.1] Small error in functions.php
« Reply #4 on: June 05, 2005, 02:24:27 AM »
I don't even have function.php in on my server. Is this normal?

Offline michi-w.

  • Hero Member
  • *****
  • Posts: 505
    • View Profile
Re: [1.7.1] Small error in functions.php
« Reply #5 on: June 05, 2005, 02:53:46 AM »
\includes\functions.php

Offline IzyB

  • Jr. Member
  • **
  • Posts: 69
    • View Profile
    • OmNamaste
Re: [1.7.1] Small error in functions.php
« Reply #6 on: July 16, 2005, 08:41:32 PM »
I just want to  make sure before I do this...am I correct in thinking that only "function check_local_thumb($remote_thumb_file)" needs to be changed? So that it should look like:

function check_local_thumb($local_thumb_file) {
  return !is_remote($local_thumb_file) && strpos($local_thumb_file, '/') !== false && preg_match("#\.[gif|jpg|jpeg|png]+$#i", $local_thumb_file) ? 1 : 0;
}

Or does everything after "function check_local_thumb($local_thumb_file)" get deleted?

Also, what does this change fix exactly?

Thanks!
Tina
Namaste,
Tina

Offline V@no

  • If you don't tell me what to do, I won't tell you where you should go :)
  • Administrator
  • 4images Guru
  • *****
  • Posts: 17.849
  • mmm PHP...
    • View Profile
    • 4images MODs Demo
Re: [1.7.1] Small error in functions.php
« Reply #7 on: July 16, 2005, 08:53:33 PM »
Or does everything after "function check_local_thumb($local_thumb_file)" get deleted?
No, only one line should be changed.

Also, what does this change fix exactly?
it fixes the function, which would return incorrect result without the fix ;)
Your first three "must do" before you ask a question:
Please do not PM me asking for help unless you've been specifically asked to do so. Such PMs will be deleted without answer. (forum rule #6)
Extension for Firefox/Thunderbird: Master Password+    Back/Forward History Tweaks (restartless)    Cookies Manager+    Fit Images (restartless for Thunderbird)

Offline IzyB

  • Jr. Member
  • **
  • Posts: 69
    • View Profile
    • OmNamaste
Re: [1.7.1] Small error in functions.php
« Reply #8 on: July 16, 2005, 09:32:34 PM »
Thanks again V@no!

Tina
Namaste,
Tina

 

Post your comments here