[1.7.1] Small error in functions.php

[Scout]

I found a small error in functions.php on line 64:

Code: [Select]

function check_local_thumb($remote_thumb_file) {
  return !is_remote($local_thumb_file) && strpos($local_thumb_file, '/') !== false && preg_match("#\.[gif|jpg|jpeg|png]+$#i", $local_thumb_file) ? 1 : 0;
}
I suppose that function definition should look like

Code: [Select]

function check_local_thumb($local_thumb_file) {


[V@no]

thank you!

[michi-w.]

Is the bugfix also 1.7?

Gruß
michi-w.

[V@no]

no

[Filip3rd]

I don't even have function.php in on my server. Is this normal?

[michi-w.]

\includes\functions.php

[IzyB]

I just want to  make sure before I do this...am I correct in thinking that only "function check_local_thumb($remote_thumb_file)" needs to be changed? So that it should look like:

function check_local_thumb($local_thumb_file) {
  return !is_remote($local_thumb_file) && strpos($local_thumb_file, '/') !== false && preg_match("#\.[gif|jpg|jpeg|png]+$#i", $local_thumb_file) ? 1 : 0;
}

Or does everything after "function check_local_thumb($local_thumb_file)" get deleted?

Also, what does this change fix exactly?

Thanks!
Tina

[V@no]

Or does everything after "function check_local_thumb($local_thumb_file)" get deleted?

No, only one line should be changed.

Also, what does this change fix exactly?

it fixes the function, which would return incorrect result without the fix

[IzyB]

Thanks again V@no!

Tina