[1.7 - 1.7.3] Security fix for SQL injection in global.php

[Jan]

This is an important security fix.

Replace the two lines in global.php (version 1.7.2 and 1.7.3) or search.php (all versions < 1.7.2):
Replace

Code: [Select]

$search_keywords = (isset($HTTP_POST_VARS['search_keywords'])) ? trim($HTTP_POST_VARS['search_keywords']) : urldecode(trim($HTTP_GET_VARS['search_keywords']));
with

Code: [Select]

$search_keywords = (isset($HTTP_POST_VARS['search_keywords'])) ? trim($HTTP_POST_VARS['search_keywords']) : trim($HTTP_GET_VARS['search_keywords']);Replace

Code: [Select]

$search_user = (isset($HTTP_POST_VARS['search_user'])) ? trim($HTTP_POST_VARS['search_user']) : urldecode(trim($HTTP_GET_VARS['search_user']));
with

Code: [Select]

$search_user = (isset($HTTP_POST_VARS['search_user'])) ? trim($HTTP_POST_VARS['search_user']) : trim($HTTP_GET_VARS['search_user']);

[mawenzi]

... thanks Jan ... and also thanks to Matt ...

[ivan]

hallo jan,
leider ist es nicht genau beschrieben

ich habe den code in global sowie in der search.php.
benutze 1.7.1, müssen beide dateien mit den codes ersetzt werden??

bei deiner beschreibung steht
bei 1.7.1 steht nur OR / müsste doch AND heissen nicht

vielen dank für deine hilfe!

gruss ivan

[Jan]

Eigentlich stehts bei 1.7.1 nicht on der global.php. Wenns bei Dir doch so ist, dann ersetze es in beiden Dateien.

[securitydot]

Thanks

[Fastian]

Thanks for keeping us up-to-date.

[brice626]

Thanks!

[cronk005]

Changing this information has dramatically changed the way the keyword search is done when using multiple languages.... now it just doesn't work at all... any thoughts?

Let me clarify... If I changed the language of my board, with appropriate Keyword language tags, it will only search for the first word in the language set and the rest of the keywords will yield strange results.

[amitpatel_3001]

Thanks a lot for notifying everyone

[amitpatel_3001]

$search_user = (isset($HTTP_POST_VARS['search_user'])) ? trim($HTTP_POST_VARS['search_user']) : urldecode(trim($HTTP_GET_VARS['search_user']));

cannot find this second line to replace

[Bugfixed]

thanks jan.

[F1boat]

Thanks a lot - Merci beaucoup

[cajebo]

Thanks a bunch for the update patch Matt & Jan.

Still one of the better stand-alone O/S Galleries


Warm regards from Downtown Miamisburg, Ohio

Michael

[Zhra]

Thanks so much sir
for keeping us up-to-date
Best regards

[Laurina]

Thank you very much.


Laurie