whos online as dropdown list

[TheOracle]

@Acidgod:

Thanks for the corrections.

Althought, I found one weakness from :

$user_profile_link = (!empty($url_show_profile)) ? preg_replace("/{user_id}/", $row['session_user_id'], $url_show_profile) : ROOT_PATH."member.php?action=showprofile&;".URL_USER_ID."=".$row['session_user_id'];

replace with :

Code: [Select]


$user_profile_link = (!empty($url_show_profile)) ? preg_replace("/{user_id}/", $row['session_user_id'], $url_show_profile) : $site_sess->url(ROOT_PATH."member.php?action=showprofile&".URL_USER_ID."=".$row['session_user_id']);


Careful when redirecting (especially under the sessions.php file).

Merry Christmas.

[V@no]

in additional a little perfomance enhansment:
instead of

Code: [Select]

preg_replace("/{user_id}/"use

Code: [Select]

str_replace("{user_id}"

[TheOracle]

Understood.

Does str_replace has a better modulation than preg_replace ? If so, in what way exacly ?

[V@no]

Well, preg_replace is for REGEX, and it works much slower. In this case there is no REGEX used, its simply string replacement, so why would use more complex function

[TheOracle]

Ah ! now I get it.

so why would use more complex function

You might want to ask Jan (for the session's core) about this and you might want to ask Nicky for the memberlist MOD about this string as well. These are the places I have discovered them. 

"BUT", I'm currently fixing these issues up as we speak.

[TheOracle]

Update: All Done !