[MOD] Download limit v1.0.1

[TheOracle]

The issue is from your download.php file where :

$sql = "SELECT cat_id, image_media_file, image_download_url
          FROM ".IMAGES_TABLE."
          WHERE image_active = 1 AND image_id IN ($image_id_sql) AND cat_id IN (".get_auth_cat_sql("auth_download").")";
  $result = $site_db->query($sql);

Would it be possible to post your paragraph to see where the error could be specificly ?

Note: Post modified above from user after this one was posted.

[V@no]

1) 4images is using HTTP_REFERER header and if you have a privacy control software that is blocking referral page you came from, 4images will not work properly on 100%. It sounds like your case.

2) Try to insert in download.php above

Code: [Select]

  $sql = "SELECT cat_id, image_media_file, image_download_url this line:

Code: [Select]

  if (empty($image_id_sql))
  {
    header("Location: ".$site_sess->url($url, "&"));
    exit;
  }

[Fastian]

With above modification, I m no more getting this DB error while using IE. That means for IE its now working fine.
But with Firefox, its still there. I tried many times clearing my internet history, clearing cache but no change.
Its strange but its happening.

I don’t have any privacy software, no proxy thing not even any anti virus software.
What could be the reason if its not by the script ?

Secondly, Is it possible to show a Message box to user instead of redirecting to the main page ? They will never know what caused them redirect to main page if using page download Mod.

One more thing. As you suggested before to change this line

Code: [Select]

if ($user_info['user_level'] == ADMIN) return; in functions.php to give Register users unlimited downloads.

The only closest thing that i have in my functions.php is this

Code: [Select]

if ($user_info['user_level'] == ADMIN)
  {
    $return = true;
    foreach ($types as $key)
    {
      if (isset($HTTP_GET_VARS[$key]) && $$key = $HTTP_GET_VARS[$key]) $return = false;
      else $$key = "";
    }
    if ($return) return false;
    $force = true;
  }
Which is inside check_ban() function.  (From "[MOD] Ban v1.6.1" by U )
Dont you think changing this will remove the ban from user ??? Or cause any trouble ? 

@ TheOracle 
My whole download.php file is attached.

[V@no]

Ok
1) if you are trying download single image while your download limit is reached (from details page), does it redirects you to index.php too?
2) you can try insert below

Code: [Select]

elseif ($action == "page") {this line:

Code: [Select]

  $url = (empty($url)) ? ROOT_PATH."categories.php?".URL_CAT_ID."=".$cat_id : $url;Then in categories.php above

Code: [Select]

//-----------------------------------------------------
//--- Clickstream -------------------------------------
//-----------------------------------------------------
insert this:

Code: [Select]

/*
  MOD DOWNLOAD LIMIT
  BEGIN INSERT
*/
if ($msg_error = $site_sess->get_session_var("msg_error"))
{
  $msg .= ((empty($msg)) ? "" : "<br />").stripslashes($msg_error);
  $site_sess->drop_session_var("msg_error");
}
/*
  MOD DOWNLOAD LIMIT
  END INSERT
*/

[Fastian]

1) if you are trying download single image while your download limit is reached (from details page), does it redirects you to index.php too?

Yes It deos. Infect in all three cases ( WIth Lightbox, SIngle file download or with category page download) it redirects to the main page when users is off the limit. BUT this happen only with IE

WIth FireFox, it gives a blank page In first two cases and for page download it still gives the DB error message.

I have done the changes u mentioned above (The last one) But still its the same no difference at all.

[ato]

Hi V@no,

das funktioniert sehr gut.
aber was muss ich machen,um das Automatische nicht mehr zu entsteht (sieht link) ?, und die Mitglieder kann nur ein *.gif Bild speichern (wie deine Seite)

http://fire.prohosting.com/nlminh/img/123.jpg oder http://nlminh.com.co.nr/img/123.jpg

[V@no]

find a topic "pic security" its all there

[Fastian]

I am stuck with it. Still redirecting using IE and still giving DB error message with FireFox. I don’t know what’s the big difference between the two explorers but I cant understand why its showing DB error message.

If for now, I put aside the redirect issue (Its important but not that much)
V@no could you please have a look and see why its giving DB error message?? 

Can I PM you the URL  (If u need) ?

[V@no]

Can I PM you the URL (If u need) ?

Please do

[V@no]

With above modification, I m no more getting this DB error while using IE. That means for IE its now working fine.
But with Firefox, its still there. I tried many times clearing my internet history, clearing cache but no change.
Its strange but its happening.

Actualy the error showed in both browser, its just IE was obeying the redirect header, while FF ignoring it. I've updated the code above that should fix it.

There something else you did in global.php (I asume) that causes the wrong redirection.

[Fastian]

Here is the update.

By adding this

Code: [Select]

  if (empty($image_id_sql))
  {
    header("Location: ".$site_sess->url($url, "&"));
    exit;
  }I no more get DB error message. Thanks V@no for helping me out.

Now could please guide me here, where should I start digging into this problem.
Why it get redirect to main page using IE? And get a Blank page using any other browser. ( I just found out that it happens with Opera as well)
I just want to show an error message just like when u right click on the pic.

What exactly the code statement that is used to redirect (so that i can double check it)??
By the way, Is it the default way or I m the only victim here?

There something else you did in global.php (I asume) that causes the wrong redirection.

V@no I compared it with the new 1.7.1 version file. It’s exactly the same.  I haven’t changed anything is this file.

[V@no]

V@no I compared it with the new 1.7.1 version file. It’s exactly the same.  I haven’t changed anything is this file.

Then I see you are using the "search engine friendly url" mod. Did you change it's code so it would replace index.php with empty string? if so, try make it replace index.php with ./ instead.

[Fastian]

V@no, Thanks a million

Its been two days now and I was trying everything, looking into page_header.php and function.php files, finding some clue that could solve the issue.
Mainly I was looking for this line and trying to get some idea. I believe this calls for redirect. 

Code: [Select]

header("Location: ".$site_sess->url($url, "&")); But I guess I was looking in wrong place with wrong code.

Just incase, if someone is interested (got the same issue) ,
 I replaced

Code: [Select]

if (strstr($url, 'index.php')) {
        $url = str_replace('index.php', '', $url);
With

Code: [Select]

if (strstr($url, 'index.php')) {
        $url = str_replace('index.php', './', $url);
in include/sessions.php file and now i am no more getting blank page with FF and Opera. (Both now redirect to main page)

Once again, Thanks for helping me out.

[TheOracle]

@Fastian:

It could also be stated like this :

Code: [Select]


if (strstr($url, 'index.php')) {
        $url = str_replace('index.php', ROOT_PATH, $url);



[V@no]

@Fastian:
You've solved only half of the mistery..the another half is - why it redirects to index page and not to the last visited...
For testing purpose, in download.php below <?php insert this:

Code: [Select]

echo "<pre>";
print_r($_SERVER);
exit;Now, open image details page and click download button. It should show you some stuff on blank page, check if you get [HTTP_REFERER] => some address
If you do, then in global.php above

Code: [Select]

if (defined("SCRIPT_URL") && SCRIPT_URL != "") { insert:

Code: [Select]

echo $url;
Then on every page you go, it should show you on top the previous page URL and not url to index.php
If all that is correct, then there is somewhere in other files you've modified, variable $url is being altered...that what you should start digging

@Fastian:

It could also be stated like this:

Its not recommended, because in ACP ROOT_PATH is different.