[small bug report] 1.7.3 in ACP

[sajwal]

Hi,
   This feed back is just to report weather the below lines are some small error i suppose while i try to add category in ACP and if i do not put any field and hit the add button these lines are shown .... actually there should be a valid message to be prompted.

Please recheck the marked fields.


Warning: Cannot modify header information - headers already sent by (output started at C:\wamp\www\impgal\4images1.7.3\4images\admin\categories.php:546) in C:\wamp\www\impgal\4images1.7.3\4images\admin\admin_functions.php on line 168

Warning: Cannot modify header information - headers already sent by (output started at C:\wamp\www\impgal\4images1.7.3\4images\admin\categories.php:546) in C:\wamp\www\impgal\4images1.7.3\4images\admin\admin_functions.php on line 169

Warning: Cannot modify header information - headers already sent by (output started at C:\wamp\www\impgal\4images1.7.3\4images\admin\categories.php:546) in C:\wamp\www\impgal\4images1.7.3\4images\admin\admin_functions.php on line 170

Warning: Cannot modify header information - headers already sent by (output started at C:\wamp\www\impgal\4images1.7.3\4images\admin\categories.php:546) in C:\wamp\www\impgal\4images1.7.3\4images\admin\admin_functions.php on line 171

Warning: Cannot modify header information - headers already sent by (output started at C:\wamp\www\impgal\4images1.7.3\4images\admin\categories.php:546) in C:\wamp\www\impgal\4images1.7.3\4images\admin\admin_functions.php on line 172


pls. excuse if its not a bug ... newbie ...

[V@no]

Thanks for reporting this.
Yes, its a bug (though it doesnt appier on every server, thats why it was unknown untill now )

A quick fix is replace in admin/categories.php

Code: [Select]

  if ($msg != "") {
    printf("<b>%s</b>\n", $msg);
  }

  show_admin_header();
With this:

Code: [Select]

  show_admin_header();

  if ($msg != "") {
    printf("<b>%s</b>\n", $msg);
  }

This issue will also be showed if you leave empty fields while editing a category.
Find:

Code: [Select]

  if ($msg != "") {
    printf("<b>%s</b>\n", $msg);
  }
  $cat_id = (isset($HTTP_POST_VARS['cat_id'])) ? intval($HTTP_POST_VARS['cat_id']) : intval($HTTP_GET_VARS['cat_id']);

  $sql = "SELECT cat_name, cat_description, cat_parent_id, cat_hits, cat_order, auth_viewcat, auth_viewimage, auth_download, auth_upload, auth_directupload, auth_vote, auth_sendpostcard, auth_readcomment, auth_postcomment
          FROM ".CATEGORIES_TABLE."
          WHERE cat_id = $cat_id";
  $cat_row = $site_db->query_firstrow($sql);

  show_admin_header();
Replace with:

Code: [Select]

  show_admin_header();
  if ($msg != "") {
    printf("<b>%s</b>\n", $msg);
  }
  $cat_id = (isset($HTTP_POST_VARS['cat_id'])) ? intval($HTTP_POST_VARS['cat_id']) : intval($HTTP_GET_VARS['cat_id']);

  $sql = "SELECT cat_name, cat_description, cat_parent_id, cat_hits, cat_order, auth_viewcat, auth_viewimage, auth_download, auth_upload, auth_directupload, auth_vote, auth_sendpostcard, auth_readcomment, auth_postcomment
          FROM ".CATEGORIES_TABLE."
          WHERE cat_id = $cat_id";
  $cat_row = $site_db->query_firstrow($sql);



[sajwal]

Thanks for reporting this.
Yes, its a bug (though it doesnt appier on every server, thats why it was unknown untill now )

A quick fix is replace in admin/categories.php

Code: [Select]

  if ($msg != "") {
    printf("<b>%s</b>\n", $msg);
  }

  show_admin_header();
With this:

Code: [Select]

  show_admin_header();

  if ($msg != "") {
    printf("<b>%s</b>\n", $msg);
  }

This issue will also be showed if you leave empty fields while editing a category.
Find:

Code: [Select]

  if ($msg != "") {
    printf("<b>%s</b>\n", $msg);
  }
  $cat_id = (isset($HTTP_POST_VARS['cat_id'])) ? intval($HTTP_POST_VARS['cat_id']) : intval($HTTP_GET_VARS['cat_id']);

  $sql = "SELECT cat_name, cat_description, cat_parent_id, cat_hits, cat_order, auth_viewcat, auth_viewimage, auth_download, auth_upload, auth_directupload, auth_vote, auth_sendpostcard, auth_readcomment, auth_postcomment
          FROM ".CATEGORIES_TABLE."
          WHERE cat_id = $cat_id";
  $cat_row = $site_db->query_firstrow($sql);

  show_admin_header();
Replace with:

Code: [Select]

  show_admin_header();
  if ($msg != "") {
    printf("<b>%s</b>\n", $msg);
  }
  $cat_id = (isset($HTTP_POST_VARS['cat_id'])) ? intval($HTTP_POST_VARS['cat_id']) : intval($HTTP_GET_VARS['cat_id']);

  $sql = "SELECT cat_name, cat_description, cat_parent_id, cat_hits, cat_order, auth_viewcat, auth_viewimage, auth_download, auth_upload, auth_directupload, auth_vote, auth_sendpostcard, auth_readcomment, auth_postcomment
          FROM ".CATEGORIES_TABLE."
          WHERE cat_id = $cat_id";
  $cat_row = $site_db->query_firstrow($sql);



Hello V@no, I did the required changes, but still get the same errors

[V@no]

If you did these changes, you would not get the "exact" same errors. Perhaps the changes you've made are not exact as I've posted above.

P.S. since I cant reproduce these errors, we'll need work this thing out together, so please be carefull to what you do

[sajwal]

If you did these changes, you would not get the "exact" same errors. Perhaps the changes you've made are not exact as I've posted above.

P.S. since I cant reproduce these errors, we'll need work this thing out together, so please be carefull to what you do

Yes It was my mistake ... ERROR FIXED PERFECTLY .. thank you very much