[MOD] All Comments (Alle Kommentare) V.1.6

[V@no]

... I think, $num_comments is very needed ...

You are right, my bad.

... and your $sql - hint ... I can't understand it ...
... will your hints resolved the paging bug ... ?

Well, I figured, since you have two mysql queries, first one is counting how many comments are available, then why would you want execute second query in case no comments available. It's just a little optimization.

As of the bug. Since selected page is not always correct, then $page should not be used for determine current number of a comment.
try replace
      $comment_counter = $num_rows_all-(($i+1+($page-1)*$commentperpage)-1);

with something like this:
      $comment_counter = $offset+$i+1;
 

[mawenzi]

... the "comment counter" ... we are on the right way ...
... the counter should display "Nr.1" for the first comment and e.g. "Nr.615" for the latest comment ...
... your counter code display display "Nr.615" for the first comment and "Nr.1" for the latest comment ...
... so I try the following counter code with success and without the bug Sun has shown ...

$comment_counter = $num_rows_all-($offset+$i);

... thanks V@no for your right hint ...

... I've updated the first MOD-post ... it's now "All Comments Version 1.6" ...

[Sun]

Thank you, mawenzi, V@no. It's work. 

[mawenzi]

Thank you, mawenzi, V@no. It's work. 

... nice to read ...

[V@no]

@mawenzi: the bug is still on your site

[mawenzi]

@V@no
... are you shure ... ?
... with the test, Sun has suggested ... I can't find the old paging bug ... the problem was solved ...
... maybe there is another, new one ... but I can't find it ...
... perhaps therefor we need a new test ...


PS. ... I think your (one site)-test was from your cache ...  

[Sun]

... with the test, Sun has suggested ... I can't find the old paging bug ... the problem was solved ...
... perhaps therefor we need a new test ...

Yesterday i try it in my site. Now i test it at mawenzi site. I can't repeat this error. All works. 

[mawenzi]

@Sun

... thanks for your testings and your statement ...

[nameless]

hi nice mod

but i need  -- All Comments in catagory

show all comments in a catagory

thanks

[mawenzi]

@nameless

... are there so much comments in your gallery ... ?
... btw. that needs some code-changes and changes in the sql-querys ...
... and sould this work from a link in the category ... ?

[nameless]

hi mawenzi

for example

i have 5 cat
now in this mod i will see all Comments

but if the user need to see all Comments in cat2 only becouse he is not intrested to see Comments for the other 4 cat

i hope u understand me

[mawenzi]

@ nameless and all ...
... die Erweiterung : Alle Kommentare einer Kategorie ist online ....
... the extension : All comments of a category is online ...


@ nameless
... thanks for pointing me in a new direction with this modification ...
... after installing and testing "All comments of a category" in my gallery I can say ... a very useful extension ...

[d1eter]

hello mawenzi..,

I tried to apply this All Comments mod to my community gallery

there's one small strange thing..
the posted by:

if a registered user looks at the page it displays like this:


for a guest (non-regsitered) it displays like this:


for any other page the {comment_user_name} displays the correct value, just in this comments_all.php (comments_all.html) which shows like this..

please help.
thank you!

[mawenzi]

@d1eter ...

... at all installations of "All Comments" I saw this fault the first time ...
... and at the moment I can't reproduce this mistake in the php-code ...
... please double check the lines No 137 - 140 and 177 of the mod-code ...

[d1eter]

hi mawenzi..

this is line 131-140

Code: [Select]

     if ( $user_info['user_level'] == GUEST ) {
         $comment_user_profile_link = "";
      } else {
             if ( $comment_user_id == -1 ) {
                  $comment_user_profile_link = "";
             } else {
                  $comment_user_profile_link = $site_sess->url(ROOT_PATH."member.php?action=showprofile&user_id=".$comment_user_id);
             }
      }
      $comment_user_link = ($comment_user_profile_link) ? "<a href=\"".$comment_user_profile_link."\">".$comment_user_name."</a>" : $comment_user_name;

and this is line 177

Code: [Select]

        "comment_user_name" => $comment_user_profile_link,

which one should I pay attention..

sorry.. my php knowledge is very poor...