problem/bug with BBcode URL

[BartAfterDark]

Hello.

I'm having a problem with the BBcode. I'm trying to make a link like this

Code: [Select]

[url=http://nokia.com]http://www.nokia.com/6230i[/url]
But 4images does not even look at the URL= http://nokia.com it just keeps using nokia.com/6230i as the link even thoe the url should be nokia

[V@no]

yes, I've seen this before...I'll add it to the list for v1.7.3

[BartAfterDark]

great, you do not have any work around atm?

[V@no]

Ok, here is a quick solution (borrowed from SMF code )
in includes/functions.php find:

Code: [Select]

function replace_url($text) {
  $text = " ".$text." ";
  $url_search_array = array(
    "#([^]_a-z0-9-=\"'\/])([a-z]+?)://([^, \(\)<>\n\r]+)#si",
    "#([^]_a-z0-9-=\"'\/])www\.([a-z0-9\-]+)\.([a-z0-9\-.\~]+)((?:/[^, \(\)<>\n\r]*)?)#si"
  );

  $url_replace_array = array(
    "\\1<a href=\"\\2://\\3\" target=\"_blank\" rel=\"nofollow\">\\2://\\3</a>",
    "\\1<a href=\"http://www.\\2.\\3\\4\" target=\"_blank\" rel=\"nofollow\">www.\\2.\\3\\4</a>"
  );
  $text = preg_replace($url_search_array, $url_replace_array, $text);

  if (strpos($text, "@")) {
    $text = preg_replace("#([\n ])([a-z0-9\-_.]+?)@([\w\-]+\.([\w\-\.]+\.)?[\w]+)#i", "\\1<a href=\"mailto:\\2@\\3\">\\2@\\3</a>", $text);
  }
  return substr($text, 1, -1);
}
Replace with:

Code: [Select]

function replace_url($text) {
  $text = strtr($text, array('&#039;' => '\'', '&nbsp;' => '\xA0', '&quot;' => '>">', '"' => '<"<', '&lt;' => '<lt<'));
  $text = preg_replace(array('~(?<=[\s>\.(;\'"])((?:http|https|ftp|ftps)://[\w\-_@:|]+(?:\.[\w\-_]+)*(?::\d+)?(?:/[\w\-_\~%\.@,\?&;=#+:\']*|\([\w\-_\~%\.@,\?&;=#()+:\']*)*[/\w\-_\~%@\?;=#])~i', '~(?<=[\s>(\'])(www(?:\.[\w\-_]+)+(?::\d+)?(?:/[\w\-_\~%\.@,\?&;=#+:\']*|\([\w\-_\~%\.@,\?&;=#()+:\']*)*[/\w\-_\~%@\?;=#])~i'), array('[url]$1[/url]', '[url=http://$1]$1[/url]'), $text);
  $text = strtr($text, array('\'' => '&#039;', '\xA0' => '&nbsp;', '>">' => '&quot;', '<"<' => '"', '<lt<' => '&lt;'));

  if (strpos($text, "@")) {
    $text = preg_replace("#([\n ])([a-z0-9\-_.]+?)@([\w\-]+\.([\w\-\.]+\.)?[\w]+)#i", "\\1<a href=\"mailto:\\2@\\3\">\\2@\\3</a>", $text);
  }
  return $text;
}

Then find:

Code: [Select]

  if ($html !== 2) {
    $text = nl2br(trim($text));
    $text = replace_url($text);
  }
Move these four lines above

Code: [Select]

  if ($bbcode == 1) {

[BartAfterDark]

When I use http:// in details now it does only shows [code][url=http://nokia.com]http://www.nokia.com/6230i[/code] and not as a link

[V@no]

Then find:

Code: [Select]

  if ($html !== 2) {
    $text = nl2br(trim($text));
    $text = replace_url($text);
  }
Move these four lines above

Code: [Select]

  if ($bbcode == 1) {

did you missed that step or maybe you copied instead of moving it?

[BartAfterDark]

I did that

Code: [Select]

  if ($html == 0 || $html == 2) {
        $text = safe_htmlspecialchars($text);
  }
  if ($html !== 2) {
  $text = nl2br(trim($text));
$text = replace_url($text);
  }

  if ($bbcode == 1) {
    $search_array = array(
But the problem is not in comments, only if I use it in details

[V@no]

Ok, lets start from the beginning.
1) Where exactly is the problem?
2) can you use BBCode there? If not, then maybe by using this 4 lines instead would solve the problem:

Code: [Select]

  if ($html !== 2 && $bbcode == 1) {
    $text = nl2br(trim($text));
    $text = replace_url($text);
  }(basicaly it will not auto convert urls into links if bbcode is not enabled for that particular text)

[BartAfterDark]

arg my bad :/ I was pretty sure bbcode worked in description. [stupid me]