4images Issues / Ausgaben > Feedback & Suggestions

4images 1.8 - Feedback

<< < (2/4) > >>

qBass17:
Here is a detailed list of what has been changed in the php files from 4images 1.7.13 -> 1.8.
(The best way for yourself to compare the code of files is to use Winmerge.)

Open: admin/comments.php

--- Quote ---search:
if ($action == "") {
  $action = "modifycomments";
}
add after
$orderbyOptions = array(
  'i.image_name' => $lang['field_image_name'],
  'c.image_id' => $lang['image'] . ' ID',
  'c.user_name' => $lang['field_username'],
  'c.comment_headline' => $lang['field_headline'],
  'c.comment_date' => $lang['field_date'],
);
search
  <select name="orderby">
  <option value="i.image_name" selected><?php echo $lang['field_image_name'] ?></option>
  <option value="c.image_id" selected><?php echo $lang['image'] ?> ID</option>
  <option value="c.user_name"><?php echo $lang['field_username'] ?></option>
  <option value="c.comment_headline"><?php echo $lang['field_headline'] ?></option>
  <option value="c.comment_date"><?php echo $lang['field_date'] ?></option>
  </select>
replace with

  <select name="orderby">
  <?php foreach ($orderbyOptions as $field => $label): ?>
  <option value="<?php echo $field; ?>"><?php echo $label; ?></option>
  <?php endforeach; ?>
  </select>
search
  $orderby = trim($HTTP_POST_VARS['orderby']);
  if ($orderby == "") {
    $orderby = "i.image_name";
replace with
  $orderby = trim($HTTP_POST_VARS['orderby']);
  if (!isset($orderbyOptions[$orderby])) {
    $orderby = "i.image_name";
  }
search
  if (isset($HTTP_GET_VARS['direction']) || isset($HTTP_POST_VARS['direction'])) {
    $direction = (isset($HTTP_GET_VARS['direction'])) ? trim($HTTP_GET_VARS['direction']) : trim($HTTP_POST_VARS['direction']);
  }
  else {
    $direction = "ASC";
  }
replace with
  $direction = "ASC";
  if (isset($HTTP_GET_VARS['direction']) || isset($HTTP_POST_VARS['direction'])) {
    $requestedDirection = (isset($HTTP_GET_VARS['direction'])) ? trim($HTTP_GET_VARS['direction']) : trim($HTTP_POST_VARS['direction']);

    if ('DESC' === $requestedDirection) {
      $direction = "DESC";
    }
  }
--- End quote ---

Open: admin/images.php

--- Quote ---search
if ($action == "") {
  $action = "modifyimages";
}
add after
$orderbyOptions = array(
  'i.image_name' => $lang['field_image_name'],
  'i.image_media_file' => $lang['field_image_file'],
  'i.image_thumb_file' => $lang['field_thumb_file'],
  'i.cat_id' => $lang['field_category'],
  'i.image_date' => $lang['field_date'],
  'i.image_downloads' => $lang['field_downloads'],
  'i.image_rating' => $lang['field_rating'],
  'i.image_votes' => $lang['field_votes'],
  'i.image_hits' => $lang['field_hits'],
);
search
  <select name="orderby">
  <option value="i.image_name" selected><?php echo $lang['field_image_name'] ?></option>
  <option value="i.image_media_file"><?php echo $lang['field_image_file'] ?></option>
  <option value="i.image_thumb_file"><?php echo $lang['field_thumb_file'] ?></option>
  <option value="i.cat_id"><?php echo $lang['field_category'] ?></option>
  <option value="i.image_date"><?php echo $lang['field_date'] ?></option>
  <option value="i.image_downloads"><?php echo $lang['field_downloads'] ?></option>
  <option value="i.image_rating"><?php echo $lang['field_rating'] ?></option>
  <option value="i.image_votes"><?php echo $lang['field_votes'] ?></option>
  <option value="i.image_hits"><?php echo $lang['field_hits'] ?></option>
  </select>
replace with
  <select name="orderby">
  <?php foreach ($orderbyOptions as $field => $label): ?>
  <option value="<?php echo $field; ?>"><?php echo $label; ?></option>
  <?php endforeach; ?>
  </select>
search
  $orderby = trim($HTTP_POST_VARS['orderby']);
  if ($orderby == "") {
    $orderby = "i.image_name";
  }
replace with
  $orderby = trim($HTTP_POST_VARS['orderby']);
  if (!isset($orderbyOptions[$orderby])) {
    $orderby = "i.image_name";
  }
search
  if (isset($HTTP_GET_VARS['direction']) || isset($HTTP_POST_VARS['direction'])) {
    $direction = (isset($HTTP_GET_VARS['direction'])) ? trim($HTTP_GET_VARS['direction']) : trim($HTTP_POST_VARS['direction']);
  }
  else {
    $direction = "ASC";
  }
replace with
  $direction = "ASC";
  if (isset($HTTP_GET_VARS['direction']) || isset($HTTP_POST_VARS['direction'])) {
    $requestedDirection = (isset($HTTP_GET_VARS['direction'])) ? trim($HTTP_GET_VARS['direction']) : trim($HTTP_POST_VARS['direction']);

    if ('DESC' === $requestedDirection) {
      $direction = "DESC";
    }
  }

--- End quote ---

Open: admin/progress.php

--- Quote ---search

--- Code: ---<body onload="start_animation()">
--- End code ---
replace with

--- Code: ---<body onLoad="start_animation()">
--- End code ---

--- End quote ---

Open: admin/users.php

--- Quote ---search
if ($action == "") {
  $action = "modifyusers";
}
add after
$orderbyOptions = array(
  get_user_table_field("", "user_name") => $lang['field_username'],
  get_user_table_field("", "user_email") => $lang['field_email'],
  get_user_table_field("", "user_joindate") => $lang['field_joindate'],
  get_user_table_field("", "user_lastaction") => $lang['field_lastaction'],
);
search
  <select name="orderby">
  <option value="<?php echo get_user_table_field("", "user_name"); ?>" selected><?php echo $lang['field_username']; ?></option>
  <option value="<?php echo get_user_table_field("", "user_email"); ?>"><?php echo $lang['field_email']; ?></option>
  <option value="<?php echo get_user_table_field("", "user_joindate"); ?>"><?php echo $lang['field_joindate']; ?></option>
  <option value="<?php echo get_user_table_field("", "user_lastaction"); ?>"><?php echo $lang['field_lastaction']; ?></option>
  </select>
replace with
  <select name="orderby">
  <?php foreach ($orderbyOptions as $field => $label): ?>
  <option value="<?php echo $field; ?>"><?php echo $label; ?></option>
  <?php endforeach; ?>
  </select>
search
  $orderby = trim($HTTP_POST_VARS['orderby']);
  if ($orderby == "") {
    $orderby = get_user_table_field("", "user_name");
  }
replace with
  $orderby = trim($HTTP_POST_VARS['orderby']);
  if (!isset($orderbyOptions[$orderby])) {
    $orderby = get_user_table_field("", "user_name");
  }
search
  if (isset($HTTP_GET_VARS['direction']) || isset($HTTP_POST_VARS['direction'])) {
    $direction = (isset($HTTP_GET_VARS['direction'])) ? trim($HTTP_GET_VARS['direction']) : trim($HTTP_POST_VARS['direction']);
  }
  else {
    $direction = "ASC";
  }
replace with
  $direction = "ASC";
  if (isset($HTTP_GET_VARS['direction']) || isset($HTTP_POST_VARS['direction'])) {
    $requestedDirection = (isset($HTTP_GET_VARS['direction'])) ? trim($HTTP_GET_VARS['direction']) : trim($HTTP_POST_VARS['direction']);

    if ('DESC' === $requestedDirection) {
      $direction = "DESC";
    }
  }

--- End quote ---

Open: admin/validateimages.php

--- Quote ---search
  if (isset($HTTP_GET_VARS['orderby']) || isset($HTTP_POST_VARS['orderby'])) {
    $orderby = (isset($HTTP_GET_VARS['orderby'])) ? stripslashes(trim($HTTP_GET_VARS['orderby'])) : stripslashes(trim($HTTP_POST_VARS['orderby']));
  }
  else {
    $orderby = "i.image_date";
  }
replace with
  $orderbyOptions = array(
    'i.image_name' => $lang['field_image_name'],
    'i.cat_id' => $lang['field_category'],
    'i.image_date' => $lang['field_date'],
    get_user_table_field("u.", "user_name") => $lang['field_username']
  );

  $orderby = "i.image_date";

  if (isset($HTTP_GET_VARS['orderby']) || isset($HTTP_POST_VARS['orderby'])) {
    $requestedOrderby = (isset($HTTP_GET_VARS['orderby'])) ? stripslashes(trim($HTTP_GET_VARS['orderby'])) : stripslashes(trim($HTTP_POST_VARS['orderby']));

    if (isset($orderbyOptions[$requestedOrderby])) {
      $orderby = $requestedOrderby;
    }
  }
search
  if (isset($HTTP_GET_VARS['direction']) || isset($HTTP_POST_VARS['direction'])) {
    $direction = (isset($HTTP_GET_VARS['direction'])) ? trim($HTTP_GET_VARS['direction']) : trim($HTTP_POST_VARS['direction']);
  }
  else {
    $direction = "ASC";
  }
replace with
  $direction = "ASC";
  if (isset($HTTP_GET_VARS['direction']) || isset($HTTP_POST_VARS['direction'])) {
    $requestedDirection = (isset($HTTP_GET_VARS['direction'])) ? trim($HTTP_GET_VARS['direction']) : trim($HTTP_POST_VARS['direction']);

    if ('DESC' === $requestedDirection) {
      $direction = "DESC";
    }
  }
search
  <select name="orderby">
  <option value="i.image_name" selected><?php echo $lang['field_image_name'] ?></option>
  <option value="i.cat_id"><?php echo $lang['field_category'] ?></option>
  <option value="i.image_date"><?php echo $lang['field_date'] ?></option>
  <option value="<?php echo get_user_table_field("u.", "user_name"); ?>"><?php echo $lang['field_username'] ?></option>
  </select>
replace with
  <select name="orderby">
  <?php foreach ($orderbyOptions as $field => $label): ?>
  <option value="<?php echo $field; ?>"><?php echo $label; ?></option>
  <?php endforeach; ?>
  </select>

--- End quote ---

Open: includes/constants.php

--- Quote ---search
define('SCRIPT_VERSION', '1.7.13');
replace with
define('SCRIPT_VERSION', '1.8');

--- End quote ---

Open: includes/db_mysql.php

--- Quote ---search
  function Db($db_host, $db_user, $db_password = "", $db_name = "", $db_pconnect = 0) {
replace with
  function __construct($db_host, $db_user, $db_password = "", $db_name = "", $db_pconnect = 0) {
search
$this->error("Could not connect to the database server ($db_host, $db_user).", 1);
replace with
$this->error("Could not connect to the database server (".safe_htmlspecialchars($db_host).", ".safe_htmlspecialchars($db_user).").", 1);
search
$this->error("Could not select database ($db_name).", 1);
replace with
$this->error("Could not select database (".safe_htmlspecialchars($db_name).").", 1);
search
    return $this->connection;
  }

  function escape($value) {
    return mysql_real_escape_string($value, $this->connection);
  }
replace with
    mysql_set_charset('utf8', $this->connection);
    return $this->connection;
  }

  function escape($value) {
    return mysql_real_escape_string($value, $this->connection);
  }
search
$this->error("<b>Bad SQL Query</b>: ".htmlentities($query)."<br /><b>".mysql_error()."</b>");
replace with
$this->error("<b>Bad SQL Query</b>: ".safe_htmlspecialchars($query)."<br /><b>".safe_htmlspecialchars(mysql_error())."</b>");

--- End quote ---

Open: includes/email.php

--- Quote ---search
  function Email() {
replace with
  function __construct() {
search
global $config;
add after
global $lang;
search
    return $header;
  }
replace with
    $header .= "Content-Type: text/plain; charset=" . strtolower($lang['charset']) . "\r\n";
    return $header;
  }

--- End quote ---

Open: includes/page_header.php

--- Quote ---search
if ($csrf_protection_enable && $csrf_protection_frontend) {
    csrf_start(true);
}
add after
if (!headers_sent()) {
  header('Content-Type: text/html;charset=' . $lang['charset'], true);
}

--- End quote ---

Open: includes/paging.php

--- Quote ---search
 function Paging($page = 1, $perpage = 0, $num_rows_all = 0, $link_args = "") {
replace with
  function __construct($page = 1, $perpage = 0, $num_rows_all = 0, $link_args = "") {

--- End quote ---

Open: includes/sessions.php

--- Quote ---search
  function Session() {
replace with
 function __construct() {

--- End quote ---

Open: includes/template.php

--- Quote ---search
  function Template($template_path = "") {
replace with
  function __construct($template_path = "") {

--- End quote ---

Open: includes/upload.php

--- Quote ---search
  function Upload() {
replace with
  function __construct() {

--- End quote ---

Open: includes/zip.php

--- Quote ---search
 function Zipfile($level = 9) {
replace with
  function __construct($level = 9) {

--- End quote ---

Open: lang/(deutsch/spanish/english)/main.php

--- Quote ---search
$lang['charset'] = "iso-8859-1";
replace with
$lang['charset'] = "UTF-8";

--- End quote ---

Nosferatu:
Many thanks!!!

Problem 1:
Ich hab allerdings einen fehler beim Text wenn ich auf

 $lang['charset'] = "UTF-8";

ändere - dann habe ich ein paar "?"  

somit lasse ich
$lang['charset'] = "iso-8859-1";

Ist das Problematisch?

Problem 2
Weiteres habe ich immer noch das Problem, dass bei einigen Dingen wo man ändern will - der Link falsch angezeigt wird also

z.b: in der images.php
habe ich http://www.domain.com/picgallerie/.data/media/334/taylor.jpg
statt http://www.domain.com/picgallerie/data/media/334/taylor.jpg

Und die verlinken zu images hauen auch nicht hin die habe ich damals mit müh und not umgebaut, damit ich Bilder bearbeiten kann bzw. das selbe problem ist auch wenn ich ein kommentar bearbeiten will, dass ich gar nicht hin komme weil er

http://www.domain.com/picgallerie/admin/index.php?goto=comments.php%3Faction%3Deditcomment%26amp%3Bcomment_id%3D19603

kommt dann
Not Found
The requested URL /picgallerie/admin/comments.php?action=editcomment&amp;comment_id=19604 was not found on this server.

Wenn ich dann händisch eingebe
http://www.domain.com/picgallerie/admin/comments.php?action=editcomment&comment_id=19604

dann funktioniert es

qBass17:
Zu Problem 1: Kannst du ruhig so lassen

Zu Problem zwei, die Umlaute werden falsch gesetzt.
Da wirst du wohl durch modifikationen etwas geändert haben.

http://www.domain.com/picgallerie/admin/index.php?goto=comments.php%3Faction%3Deditcomment%26amp%3Bcomment_id%3D19603
%3F ist ?
%3D ist =
&amp; ist &

Nosferatu:
Meinst beim Script selber?
Wüsste nicht, dass ich beim Script da was gemacht habe bzw. benötige ich nur ganz selten die Edit oder Löschen Funktion - daher ist es mir erst irgendwann aufgefallen  :oops:

Wo wäre dies denn und wie könnte ich es ändern?

ASAD:
Hi Leute!
Kann ich von 1.7.11 Update auf 1.8?

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version