watermark when showing pic

[V@no]

not showing as what? as a broken image or no image at all?
if its a broken image (red x) then what is the path to it in the page source?

[okram]

well i think i should remove this lines from the watermark.php

Code: [Select]

if (!check_permission("auth_viewcat", $cat_id) || !check_permission("auth_viewimage", $cat_id) || !$image_row)
{
  die("No permission");
}
in that way it workks correctly..... id it good?

thanks

[triaphoto]

nice idea!

maybe its a little bit off topic but i think your pictures will suffer a certain loss of quality by watermarking them "on the fly".

the best workflow is:
1. open the picture in original size
2. reduce the size
3. watermark it
4. save it.

never save between step 2 and 3, close the picture and open it again.
So I think its a better idea to upload the unmarked AND the watermarked picture. Or to upload a picture a little bit bigger in size than the output and add an additional command "reduce size" before watermarking the picture.

 

 

[okram]

maybe its a little bit off topic but i think your pictures will suffer a certain loss of quality by watermarking them "on the fly".

well i'm using this method and the watermarked pictures are as good as the original ones...

the best workflow is:
1. open the picture in original size
2. reduce the size
3. watermark it
4. save it.

never save between step 2 and 3, close the picture and open it again.
So I think its a better idea to upload the unmarked AND the watermarked picture. Or to upload a picture a little bit bigger in size than the output and add an additional command "reduce size" before watermarking the picture.

could you explain it a bit better? i did not understand 

greets 

[triaphoto]

ok no prob:
every time you save a jpeg-picture this results in a certain loss of quality.

so if you have to modify a picture NEVER:
save between the steps
close the picture
and open the partially modified picture again to go on with the modification.

for example: by saving the picture you get a quality loss of 10%

if you save the picture AFTER the complete workflow: 10%
if you save it, close it  and reopen it DURING the workflow: 20%

the effect is similar when you use a graphic library.

edit: its no problem if you just save it during the workflow without closing and reopening, because the image is still in your memory
 

[okram]

yep, perhaps you're right, but like i said, my pics don't lose their quality at all when watermarking them, and if it does, it can't be more than 1 or 2 % cuz they look just as the original ones... (no better, no worse)

Greets

[ch€ri{Bi}²]

thanks for this...
I use watermark on the fly for some time     and the process works well, why not to move him towards the Mods & Plugins (Publishing & Support) forum? 

my question :  : How may I prevent the direct access to the watermark.php file? (for the moment when you call : http://your.domain.net/4images/watermark.php?image_id=xxx    it shows 1 watermark pic)
i think about a line of code at the top of the watermark.php file to verifiy if the access is direct or from a file...

Regards.

[okram]

thanks for this...
I use watermark on the fly for some time     and the process works well, why not to move him towards the Mods & Plugins (Publishing & Support) forum? 

yeah... that would be great 

How may I prevent the direct access to the watermark.php file? (for the moment when you call : http://your.domain.net/4images/watermark.php?image_id=xxx    it shows 1 watermark pic)
i think about a line of code at the top of the watermark.php file to verifiy if the access is direct or from a file...

I've been using sessions to solve this... here's the solution:

File page_header.php in includes folder:
Add this line somewhere at the beginning of the page_header.php file... I put it before $total_images = 0;

Code: [Select]

$_SESSION['_access_is_correct']="y";As far as I could see, page_header.php is included in every page of the gallery, so what we do here is just registering a new session variable -> $_SESSION['_access_is_correct']... It doesn't mind the value you gave to it...

File watermark.php at the main root:
Well the final code would be like this:
watermark.php

Code: [Select]

<?php
$nozip = 1;
$image_id = $_GET['image_id'];
define('ROOT_PATH', './');
define('GET_CACHES', 1);
include(ROOT_PATH.'global.php');
require(ROOT_PATH.'includes/sessions.php');
$user_access = get_permission();

//here we check if our session variable is set... 
//if it's not, the pic is not shown
if(!isset($_SESSION['_access_is_correct']))
  {
  die("You are not allowed to see this page");
  }
else 
  {
  //if the variable is set, it means the user is accessing 
  //the image correctly, then we show it.
  //but before showing the pic, we unset our variable for security reasons
  $_SESSION['_access_is_correct']="";
  unset($_SESSION['_access_is_correct']);

$watermark = "water.png";

if (!$image_id)
{
  die("Security violation");
}

$sql = "SELECT cat_id, image_media_file, image_thumb_file
        FROM ".IMAGES_TABLE."
        WHERE image_id = $image_id";
$image_row = $site_db->query_firstrow($sql);
$cat_id = (isset($image_row['cat_id'])) ? $image_row['cat_id'] : 0;

$im = imagecreatefrompng($watermark);

$image = MEDIA_PATH."/".$cat_id."/".$image_row['image_media_file'];
$types = array(1 => "gif", 2 => "jpeg", 3 => "png");
if ($image_info = @getimagesize($image))
{
  $image_create_handle = "imagecreatefrom".$types[$image_info[2]];
  if (!$im2 = @$image_create_handle($image))
  {
    die("Error opening $image!");
  }

  imagecopy($im2, $im, (imagesx($im2)/100)-(imagesx($im)/100), (imagesy($im2)/100)-(imagesy($im)/100), 0, 0, imagesx($im), imagesy($im));
  
    $waterless = imagesx($im2) - imagesx($im);
    $rest = ceil($waterless/imagesx($im)/1);
    
    for($n=1; $n<=$rest; $n++)
    {
      imagecopy($im2, $im, ((imagesx($im2)/100)-(imagesx($im)/100))-(imagesx($im)*$n), (imagesy($im2)/100)-(imagesy($im)/100), 0, 0, imagesx($im), imagesy($im));
      imagecopy($im2, $im, ((imagesx($im2)/100)-(imagesx($im)/100))+(imagesx($im)*$n), (imagesy($im2)/100)-(imagesy($im)/100), 0, 0, imagesx($im), imagesy($im));
    }
  header("Content-Type: image/jpeg");
  imagejpeg($im2);
  imagedestroy($im);
  imagedestroy($im2);
}
else
{
  die("Error opening $image!");
$_SESSION['_access_is_correct']="";
unset($_SESSION['_access_is_correct']);
}  
  }
?>
Try it, and if you have any problems, post a new msg here

Best regards

[Xyu BAM]

@okram:
better yet store time() in that session so it can expired in, let say, 1 minute after any page was opened.

[okram]

I really prefer unsetting the variable before showing the image...

If you set a life time for the session, 4example 1 minute, so the visitor will be able to access the watermark.php file during all that time... and what we're trying to prevent is the direct access to this file at anytime or anyway...

I think its much better if we unset our variable once we've checked that it exists and that the visitor is accessing the picture correctly...

Regards

[impss]

Can anyone help?

I use this Modification , but when someone tries to directlink it onto another forum
you get a

Sorry, dynamic pages in the [IMG] tags are not allowed

Is there anyway to fix it so it would work?

thanks for anyhelp

[okram]

I'm afraid you can't do nothing about that... If that other forum does not allow dynamic pages in its [IMG] tags, so whatever you do with your watermark.php code will not change that... watermark.php is a dynamic file, and that's why we use it to watermark serveral different pictures...

when someone tries to directlink it onto another forum
you get a

Sorry, dynamic pages in the [IMG] tags are not allowed

can i see that other forum you mentioned? can you post the url plz???

Best regards

[TheOracle]

well i think i should remove this lines from the watermark.php

Code: [Select]

if (!check_permission("auth_viewcat", $cat_id) || !check_permission("auth_viewimage", $cat_id) || !$image_row)
{
  die("No permission");
}
in that way it workks correctly..... id it good?

thanks

Rather than removing it, if you replace it

with :

Code: [Select]


if (!check_permission("auth_viewcat", $cat_id) || !check_permission("auth_viewimage", $cat_id) || !$image_row) {

show_error_page($lang['no_permission']);

} ###### End of if statement.


Will it work ?

As for this line :

$types = array(1 => "gif", 2 => "jpeg", 3 => "png");

it could always be

replaced with :

Code: [Select]


$types = str_replace(",",", ",$config['allowed_mediatypes']);




As for this one :

if (!$im2 = @$image_create_handle($image))
  {
    die("Error opening $image!");
  }

replace with :

Code: [Select]


if (!$im2 = @$image_create_handle($image)) {

show_error_page($lang['no_image_found']);

} ###### End of if statement.



[okram]

How may I prevent the direct access to the watermark.php file? (for the moment when you call : http://your.domain.net/4images/watermark.php?image_id=xxx    it shows 1 watermark pic)
i think about a line of code at the top of the watermark.php file to verifiy if the access is direct or from a file...

I was forgetting somethign in the mod i posted to solve that problem... In the page_footer.php file we need to add this line:

Code: [Select]

// This is necessary in case user did not see any picture in a page,
// and due to that, our session variable is still active and exists
if(isset($_SESSION['_access_is_correct']))
{
unset($_SESSION['_access_is_correct']);
}

Regards

[impss]

I figured that was the case  

this is the forum the gives me that error, http://www.inegma.net/mb/index.php?act=?

and another one i use just gives me a red x - http://www.impalasuperstore.com/naisso/Forum2005/



I dont use this script to watermark the pics on my site, I allow members to use the pictures on the forums by protecting the actuall image and giving them a link that uses the watermark script.

My only option might be to try to fgure out how to use .htaccess for leeched images to watermark the pictures. but as of yet, i havent been able to figure that out.

the image works on this forum though