[1.7.4] BUG in userqroups.php & solution

[vanish]

BUG in 1.7,4 when you add latest updates ("checkbox" selector type)
Description: When "checkbox" is selected (default setting now) you don't change category permission to "No"

file:
admin/usergroups.php

find:

Code: [Select]

  foreach ($auth as $key => $val) {
    $sql = "DELETE FROM ".GROUP_ACCESS_TABLE."
            WHERE cat_id = $key AND group_id = $group_id";
    $site_db->query($sql);


replace with:

Code: [Select]

  $sql = "DELETE FROM ".GROUP_ACCESS_TABLE."
          WHERE group_id = $group_id";
  $site_db->query($sql);
  foreach ($auth as $key => $val) {


Also I recommend this changes for correct look:
find:

Code: [Select]

    echo "<td class=\"tableseparator\" width=\"".$col_width."%\" align=\"center\"><input name=\"allbox[".$val."]\" type=\"checkbox\" onClick=\"CheckAllCats(this, '".$val."');\" />".$lang[$val]."</td>\n";

replace with:

Code: [Select]

    echo "<td class=\"tableseparator\" width=\"".$col_width."%\" align=\"center\">".($permission_select_type == "checkbox" ? "<input name=\"allbox[".$val."]\" type=\"checkbox\" onClick=\"CheckAllCats(this, '".$val."');\" />":"").$lang[$val]."</td>\n";


[ripejuice]

jeevani esthar bur! don't get it