• [MOD] All Comments (Alle Kommentare) V.1.6 5 0 5 1
Currently:  

Author Topic: [MOD] All Comments (Alle Kommentare) V.1.6  (Read 342968 times)

0 Members and 1 Guest are viewing this topic.

Offline V@no

  • If you don't tell me what to do, I won't tell you where you should go :)
  • Global Moderator
  • 4images Guru
  • *****
  • Posts: 17.849
  • mmm PHP...
    • View Profile
    • 4images MODs Demo
Re: [MOD] All Comments (Alle Kommentare) V.1.5
« Reply #225 on: August 06, 2009, 04:23:53 PM »
... I think, $num_comments is very needed ...
You are right, my bad.

... and your $sql - hint ... I can't understand it ...
... will your hints resolved the paging bug ... ?
Well, I figured, since you have two mysql queries, first one is counting how many comments are available, then why would you want execute second query in case no comments available. It's just a little optimization.

As of the bug. Since selected page is not always correct, then $page should not be used for determine current number of a comment.
try replace
      $comment_counter $num_rows_all-(($i+1+($page-1)*$commentperpage)-1);

with something like this:
      $comment_counter $offset+$i+1;
 
Your first three "must do" before you ask a question:
Please do not PM me asking for help unless you've been specifically asked to do so. Such PMs will be deleted without answer. (forum rule #6)
Extension for Firefox/Thunderbird: Master Password+    Back/Forward History Tweaks (restartless)    Cookies Manager+    Fit Images (restartless for Thunderbird)

Offline mawenzi

  • Moderator
  • 4images Guru
  • *****
  • Posts: 4.500
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.5
« Reply #226 on: August 06, 2009, 04:57:13 PM »
... the "comment counter" ... we are on the right way ...
... the counter should display "Nr.1" for the first comment and e.g. "Nr.615" for the latest comment ...
... your counter code display display "Nr.615" for the first comment and "Nr.1" for the latest comment ...
... so I try the following counter code with success and without the bug Sun has shown ...

$comment_counter $num_rows_all-($offset+$i);

... thanks V@no for your right hint ... ;)

... I've updated the first MOD-post ... it's now "All Comments Version 1.6" ...
Your first three "must do" before you ask a question ! ( by V@no )
- please read the Forum Rules ...
- please study the FAQ ...
- please try to Search for your answer ...

You are on search for top 4images MOD's ?
- then please search here ... Mawenzi's Top 100+ MOD List (unsorted sorted) ...

Offline Sun

  • Jr. Member
  • **
  • Posts: 96
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #227 on: August 06, 2009, 05:08:16 PM »
Thank you, mawenzi, V@no. It's work.  :)
Tatyana.
I use 4images v.1.7.6
You can answer me in English and Russian languages.
Sorry, my English is not very good.

Offline mawenzi

  • Moderator
  • 4images Guru
  • *****
  • Posts: 4.500
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #228 on: August 06, 2009, 05:13:04 PM »
Thank you, mawenzi, V@no. It's work.  :)

... nice to read ... ;)
Your first three "must do" before you ask a question ! ( by V@no )
- please read the Forum Rules ...
- please study the FAQ ...
- please try to Search for your answer ...

You are on search for top 4images MOD's ?
- then please search here ... Mawenzi's Top 100+ MOD List (unsorted sorted) ...

Offline V@no

  • If you don't tell me what to do, I won't tell you where you should go :)
  • Global Moderator
  • 4images Guru
  • *****
  • Posts: 17.849
  • mmm PHP...
    • View Profile
    • 4images MODs Demo
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #229 on: August 07, 2009, 02:18:04 AM »
@mawenzi: the bug is still on your site ;)
Your first three "must do" before you ask a question:
Please do not PM me asking for help unless you've been specifically asked to do so. Such PMs will be deleted without answer. (forum rule #6)
Extension for Firefox/Thunderbird: Master Password+    Back/Forward History Tweaks (restartless)    Cookies Manager+    Fit Images (restartless for Thunderbird)

Offline mawenzi

  • Moderator
  • 4images Guru
  • *****
  • Posts: 4.500
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #230 on: August 07, 2009, 10:04:58 AM »
@V@no
... are you shure ... ?
... with the test, Sun has suggested ... I can't find the old paging bug ... the problem was solved ...
... maybe there is another, new one ... but I can't find it ...
... perhaps therefor we need a new test ... ;)


PS. ... I think your (one site)-test was from your cache ...  :mrgreen:
« Last Edit: August 07, 2009, 10:41:15 AM by mawenzi »
Your first three "must do" before you ask a question ! ( by V@no )
- please read the Forum Rules ...
- please study the FAQ ...
- please try to Search for your answer ...

You are on search for top 4images MOD's ?
- then please search here ... Mawenzi's Top 100+ MOD List (unsorted sorted) ...

Offline Sun

  • Jr. Member
  • **
  • Posts: 96
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #231 on: August 07, 2009, 11:24:51 AM »
... with the test, Sun has suggested ... I can't find the old paging bug ... the problem was solved ...
... perhaps therefor we need a new test ... ;)

Yesterday i try it in my site. Now i test it at mawenzi site. I can't repeat this error. All works.  :)
Tatyana.
I use 4images v.1.7.6
You can answer me in English and Russian languages.
Sorry, my English is not very good.

Offline mawenzi

  • Moderator
  • 4images Guru
  • *****
  • Posts: 4.500
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #232 on: August 07, 2009, 11:34:03 AM »
@Sun

... thanks for your testings and your statement ... :)
Your first three "must do" before you ask a question ! ( by V@no )
- please read the Forum Rules ...
- please study the FAQ ...
- please try to Search for your answer ...

You are on search for top 4images MOD's ?
- then please search here ... Mawenzi's Top 100+ MOD List (unsorted sorted) ...

Offline nameless

  • Full Member
  • ***
  • Posts: 147
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #233 on: October 27, 2009, 10:05:25 AM »
hi nice mod

but i need  -- All Comments in catagory

show all comments in a catagory

thanks

Offline mawenzi

  • Moderator
  • 4images Guru
  • *****
  • Posts: 4.500
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #234 on: October 27, 2009, 11:10:27 AM »
@nameless

... are there so much comments in your gallery ... ?
... btw. that needs some code-changes and changes in the sql-querys ...
... and sould this work from a link in the category ... ?
Your first three "must do" before you ask a question ! ( by V@no )
- please read the Forum Rules ...
- please study the FAQ ...
- please try to Search for your answer ...

You are on search for top 4images MOD's ?
- then please search here ... Mawenzi's Top 100+ MOD List (unsorted sorted) ...

Offline nameless

  • Full Member
  • ***
  • Posts: 147
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #235 on: October 27, 2009, 12:36:24 PM »
hi mawenzi

for example

i have 5 cat
now in this mod i will see all Comments

but if the user need to see all Comments in cat2 only becouse he is not intrested to see Comments for the other 4 cat

i hope u understand me


Offline mawenzi

  • Moderator
  • 4images Guru
  • *****
  • Posts: 4.500
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #236 on: October 27, 2009, 02:17:11 PM »
@ nameless and all ...
... die Erweiterung : Alle Kommentare einer Kategorie ist online ....
... the extension : All comments of a category is online ...


@ nameless
... thanks for pointing me in a new direction with this modification ...
... after installing and testing "All comments of a category" in my gallery I can say ... a very useful extension ...
« Last Edit: November 04, 2009, 12:34:03 AM by mawenzi »
Your first three "must do" before you ask a question ! ( by V@no )
- please read the Forum Rules ...
- please study the FAQ ...
- please try to Search for your answer ...

You are on search for top 4images MOD's ?
- then please search here ... Mawenzi's Top 100+ MOD List (unsorted sorted) ...

Offline d1eter

  • Newbie
  • *
  • Posts: 42
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #237 on: February 18, 2010, 03:18:53 AM »
hello mawenzi..,

I tried to apply this All Comments mod to my community gallery

there's one small strange thing..
the posted by:

if a registered user looks at the page it displays like this:


for a guest (non-regsitered) it displays like this:


for any other page the {comment_user_name} displays the correct value, just in this comments_all.php (comments_all.html) which shows like this..

please help.
thank you!

Offline mawenzi

  • Moderator
  • 4images Guru
  • *****
  • Posts: 4.500
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #238 on: February 18, 2010, 10:07:44 AM »
@d1eter ...

... at all installations of "All Comments" I saw this fault the first time ...
... and at the moment I can't reproduce this mistake in the php-code ...
... please double check the lines No 137 - 140 and 177 of the mod-code ...
Your first three "must do" before you ask a question ! ( by V@no )
- please read the Forum Rules ...
- please study the FAQ ...
- please try to Search for your answer ...

You are on search for top 4images MOD's ?
- then please search here ... Mawenzi's Top 100+ MOD List (unsorted sorted) ...

Offline d1eter

  • Newbie
  • *
  • Posts: 42
    • View Profile
Re: [MOD] All Comments (Alle Kommentare) V.1.6
« Reply #239 on: February 18, 2010, 10:18:08 AM »
hi mawenzi..

this is line 131-140
Code: [Select]
     if ( $user_info['user_level'] == GUEST ) {
         $comment_user_profile_link = "";
      } else {
             if ( $comment_user_id == -1 ) {
                  $comment_user_profile_link = "";
             } else {
                  $comment_user_profile_link = $site_sess->url(ROOT_PATH."member.php?action=showprofile&user_id=".$comment_user_id);
             }
      }
      $comment_user_link = ($comment_user_profile_link) ? "<a href=\"".$comment_user_profile_link."\">".$comment_user_name."</a>" : $comment_user_name;

and this is line 177
Code: [Select]
        "comment_user_name" => $comment_user_profile_link,

which one should I pay attention..

sorry.. my php knowledge is very poor...
 :cry: