[1.7.1] Conditional tags inside other conditional tags + {ifno ...}{endifno ...}

[V@no]

Since v1.7.1 introduced new, optimized template engine, a little bug was created which would not allow use conditional tags inside other conditional tags:

{if blah}{if blah2}...{endif blah2}{endif blah}

the {if blah2}{endif blah2} would be ignored.
Also, in this fix I added new feature {ifno blah}{endifno blah} type of conditional tags. That condition is opposite of {if blah} meaning that code between these tags will be showed only if {blah} tag is empty.


Open includes/templates.php
Find:

Code: [Select]

    // Compile condition tags
    $template = preg_replace_callback(
        '='.preg_quote($this->start).'if\s+([A-Z0-9_]+)'.preg_quote($this->end).'(.*)'.preg_quote($this->start).'endif\s+(\\1+)'.preg_quote($this->end).'=Usi',
        array(&$this, '_compile_condition'),
        $template
    );Replace it with:

Code: [Select]

    // Compile condition tags
    $template = preg_replace_callback(
        '='.preg_quote($this->start).'if\s+([A-Z0-9_]+)'.preg_quote($this->end).'=Usi',
        array(&$this, '_compile_condition_start'),
        $template
    );
    $template = preg_replace_callback(
        '='.preg_quote($this->start).'endif\s+([A-Z0-9_]+)'.preg_quote($this->end).'=Usi',
        array(&$this, '_compile_condition_end'),
        $template
    );
    $template = preg_replace_callback(
        '='.preg_quote($this->start).'ifno\s+([A-Z0-9_]+)'.preg_quote($this->end).'=Usi',
        array(&$this, '_compile_condition_no_start'),
        $template
    );
    $template = preg_replace_callback(
        '='.preg_quote($this->start).'endifno\s+([A-Z0-9_]+)'.preg_quote($this->end).'=Usi',
        array(&$this, '_compile_condition_no_end'),
        $template
    );
Then find:

Code: [Select]

  function _compile_condition(&$matches) {
    return '<?php if (!empty($' . trim($matches[1]) . ') && $' . trim($matches[1]) . ' != REPLACE_EMPTY): ?>' . $matches[2] . '<?php endif; ?>';
  }Replace it with:

Code: [Select]

  function _compile_condition_start(&$matches) {
    return '<?php if (!empty($' . trim($matches[1]) . ') && $' . trim($matches[1]) . ' != REPLACE_EMPTY){ ?>';
  }
  function _compile_condition_end(&$matches) {
    return '<?php } ?>';
  }
  function _compile_condition_no_start(&$matches) {
    return '<?php if (empty($' . trim($matches[1]) . ') || $' . trim($matches[1]) . ' == REPLACE_EMPTY){ ?>';
  }
  function _compile_condition_no_end(&$matches) {
    return '<?php } ?>';
  }
P.S. if u dont need {ifno ..} feature, then I think it wouldn't be too dificult to figure out what needed to be removed

[ashantiforever]

Parse error: parse error, unexpected '}' in /home/bphotos/public_html/newsum/includes/template.php(101) : eval()'d code on line 259

For some reason .. it's giving me a parse error when I use that mod. Strange thing is that I don't even have a line 259 in the PHP coding .. it stops at 240-something

[V@no]

restore backups and try again.

[ashantiforever]

it's still doing it .. and I did all the steps over (3 times)

It's weird because it's only doing it on pages other than index.php

{ links removed }

[ashantiforever]

nevermind .. I fixed it by uploading a modified "template.php" file from 1.7

[Josef Florian]

Thanks V@no!!!

 

[karimun]

I also have a similar problem like ashantiforever described it above:
In my case it returns the parse error for index.php ONLY - the other pages seem to work with this MOD.

What more can I try? Thank you.

[karimun]

Ok, I killed this nasty bug with this fix: http://www.4homepages.de/forum/index.php?topic=6806.0

[V@no]

seems to me u have an opening conditional tag (if tag} but without closing one {endif tag} (or opposite)

[maziggy]

For me it works. Thanks for that fix

[WhiteRabbit]

Great work!

Thanks!.

Best regards.
WR.

[TXtaholic]

   thanks v@no    great effort

[megalomania]

Hello,

I am using the new 1.72 version of 4images and the {ifno...} blah {endifno...} feature doesn't work anymore, for me.
In the "Changelog.txt" it is mentioned, that the code of the 1.72 release differs from the solution in this forum post.

And since I am not very firm in PHP, it would be very helpful if someone may tell me which lines I have to change, in order to get my  {ifno...} blah {endifno...} feature back. 

Greetings, Mega

[V@no]

There is nothing needed to be changed, it should work just fine. Or perpahs you should be more describtive then saying "it doesnt work"

[koikonut]

Needs the Version 1.7.2 this Mod/Fix too?

Thanks, bye Konradin