[Possible Bug] E-Cards

[Alan @ ArtScans]

Hi,

Just been testing 4images, and tried to send a couple of e-cards, and noticed the following problems.

The time in the e-mail is missing the last number - "Your eCard has been sent on 29.06.2002 20:5".  It was infact sent at 20:53.

The link to the e-card didn't work at all.  All I got was "Invalid eCard ID", and it displays a random image.

The site in question is at http://new.artscans.co.uk (please take into account, that this site is not launching until Monday 1st July, so it's not fully working yet).

Thanks,
Alan.

[Alan @ ArtScans]

Hi folks,

Further testing has revealed that it is cutting of the final character in postcard_id as well.  This is what was causing the second error (Invalid ecard ID).

Thanks,
Alan.

[Vienix]

Same here...

 

[Vienix]

Art Scan> 1.6 >Problem ecards
http://wev9.venus.sprintweb.de/gal/ 1.6 >ok  (same template, had to check
vierstra.com > Problem ecards 1.6
bali-pictures.com > Problem ecards 1.6
www.vrulez.animescape.net ok 1.5 ( same template )
http://www.2x2online.com/4images/ ok (modified 4grey templ)
4homepages ok
http://www.mjpd.com/php/4images/ 1.6 > 4grey templ ok



I was worrying about something in the template, but that looks not like it....

Alan, did you do a clean install of 1.6 or did you only replace changed files ? ( like me )

[Alan @ ArtScans]

Hi,

I installed all 1.6 files over the top of the 1.5 files.  Then applied the new 1.6 patch on top of that.

Been doing some more testing, and have tracked the bug down to functions.php->prepare_text().  The following line seems to be causing the problem...

Code: [Select]


$message = preg_replace("/[^\r]\n/si", "\r\n", $message);


To fix it, change the line (95) above to ...

Code: [Select]


$message = preg_replace"/(?<!\r)\n/si","\r\n", $message);


Thanks,
Alan.

[Vienix]

Ah,

in email.php you mean ?

[Jan]

It's in "includes/email.php"...

Greets Jan

[Vienix]

Parse error: parse error in /www/htdocs/vierstra/pictures/includes/email.php on line 96

Fatal error: Cannot instantiate non-existent class: email in /www/htdocs/vierstra/pictures/postcards.php on line 92

After the line change??

[Alan @ ArtScans]

Sorry, yes.  It's in email.php.  Was looking at the wrong file whilst writing

Thanks,
Alan.

[Vienix]

ah it should be :

Code: [Select]

$message = preg_replace("/(?<!\r)\n/si","\r\n", $message);

Now it works, thanks

[Alan @ ArtScans]

I only find and fix the bugs, I can't be expected to type correctly as well <g>

Thanks,
Alan.

[Vienix]

<g>

It woukd be handy if users would have a email adresses database, with standard messages wouldn' you think ?

[Alan @ ArtScans]

Hi,

I'm sorry, I don't fully understand what you mean.  Are you talking about mass-emailing all users?  If so, that can be done from 4images admin panel.

If not, then sorry  I didn't understand the question fully

Thanks,
Alan.

[Vienix]

ALAN !

Every users has a email adresses dbase, for sending ecards,
with predefined messages.

Mass ecarding

( and i will not give my users access to the admin panel )

[Alan @ ArtScans]

Oh, I understand now (I think).

You mean like a personal e-mail address book for each user?  Where they can enter their friends e-mail addresses, and use it to mass-send e-cards?

If I've got it right this time  Then yes, that would be a good idea.  Wouldn't be too hard to impletment either.  I may think about writing a mod to do that once I get a free minute

(btw, I wasn't suggesting you give your users access to the cp, I thought you meant you (as the admin) wanted to mass-email )

Thanks,
Alan.