[FIX & Question] - rss.php

[thunderstrike]

Detail: Redirect to index if fail (no exit). No get why exit ...

Find:

case 'comments':
    if (!$image_id) {
      exit;
    }

    $sql = "SELECT i.image_id, i.cat_id, i.user_id, i.image_name, i.image_description, i.image_keywords, i.image_date, i.image_active, i.image_media_file, i.image_thumb_file, i.image_download_url, i.image_allow_comments, i.image_comments, i.image_downloads, i.image_votes, i.image_rating, i.image_hits, c.cat_name".get_user_table_field(", u.", "user_name").get_user_table_field(", u.", "user_email")."
            FROM (".IMAGES_TABLE." i,  ".CATEGORIES_TABLE." c)
            LEFT JOIN ".USERS_TABLE." u ON (".get_user_table_field("u.", "user_id")." = i.user_id)
            WHERE i.image_id = $image_id AND c.cat_id = i.cat_id";
    $image_row = $site_db->query_firstrow($sql);

    if (!isset($image_row['image_id'])) {
      exit;
    }

replace:

case 'comments':
    if (!$image_id) {
      redirect($url);
    }

    $sql = "SELECT i.image_id, i.cat_id, i.user_id, i.image_name, i.image_description, i.image_keywords, i.image_date, i.image_active, i.image_media_file, i.image_thumb_file, i.image_download_url, i.image_allow_comments, i.image_comments, i.image_downloads, i.image_votes, i.image_rating, i.image_hits, c.cat_name".get_user_table_field(", u.", "user_name").get_user_table_field(", u.", "user_email")."
            FROM (".IMAGES_TABLE." i,  ".CATEGORIES_TABLE." c)
            LEFT JOIN ".USERS_TABLE." u ON (".get_user_table_field("u.", "user_id")." = i.user_id)
            WHERE i.image_id = $image_id AND c.cat_id = i.cat_id AND ";
    $image_row = $site_db->query_firstrow($sql);

    if (!isset($image_row['image_id'])) {
      redirect($url);
    }

Question - No get why is there:

'link' => $site_sess->url($script_url."/details.php?".URL_IMAGE_ID."=".$row['image_id']),

is use:

Code: [Select]

'link' => $site_sess->url(ROOT_PATH."details.php?".URL_IMAGE_ID."=".$row['image_id']),

or is use:

Code: [Select]

'link' => format_url($script_url."/details.php?".URL_IMAGE_ID."=".$row['image_id']),

Which good ?