[MOD] All Comments (Alle Kommentare) V.1.6

[zoolmann]

It's not functional (it is no go) 

[V@no]

In comments_all.php find:

Code: [Select]

      $sql = "SELECT i.image_id, i.cat_id, i.image_name, c.cat_name, i.image_media_file, i.image_thumb_fileReplace it with:

Code: [Select]

      $sql = "SELECT i.image_id, i.cat_id, i.image_name, c.cat_name, i.image_media_file, i.image_thumb_file".get_user_table_field(", u.", "user_id").get_user_table_field(", u.", "user_level").get_user_table_field(", u.", "user_name")."
Then find:

Code: [Select]

        "admin_links" => $admin_links,Insert ^above:

Code: [Select]

        "image_user_name" => ($image_row[$user_table_fields['user_level']] != GUEST) ? "<a href=\"".$site_sess->url(ROOT_PATH."member.php?action=showprofile&amp;user_id=".$image_row[$user_table_fields['user_id']])."\">".htmlspecialchars($image_row[$user_table_fields['user_name']])."</a>" : $lang['userlevel_guest'],Then in template you can use {image_user_name}

[mawenzi]

@ V@no

... thanks for this nice additive ... 
... I will integrate it into the MOD ...

... little mistake ... this ..

... $user_table_fields['user_id']]."\">".htmlspecialchars($image_row[ ...

should be

... $user_table_fields['user_id']])."\">".htmlspecialchars($image_row[ ...

mawenzi

[TheOracle]

In the mean time, I believe I know why this string $user_table_fields is being used now.

However, I wonder if this one can be applied over user additional fields or only on user core fields ...

[V@no]

... I will integrate it into the MOD ...

Oh, ok
And while you at it, I have a suggestion, not really important, but in this query:

Code: [Select]

  $sql = "SELECT c.comment_id, c.image_id, c.user_id, c.user_name AS comment_user_name, c.comment_headline, c.comment_text, c.comment_date".get_user_table_field(", u.", "user_level").get_user_table_field(", u.", "user_name").get_user_table_field(", u.", "user_lastaction").get_user_table_field(", u.", "user_comments").$additional_sql."
          FROM ".COMMENTS_TABLE." c
          LEFT JOIN ".USERS_TABLE." u ON (".get_user_table_field("u.", "user_id")." = c.user_id)
          LEFT JOIN ".IMAGES_TABLE." i ON (i.image_id = c.image_id) ".$add_where."
          ORDER BY c.comment_date DESC
          LIMIT $offset, $commentperpage";actualy don't need include USERS_TABLE table, because later on you are using

Code: [Select]

$user_row_comment = get_user_info($comment_user_id);which fetch all needed information about the user of the comment
so, this query should do just fine:

Code: [Select]

  $sql = "SELECT c.comment_id, c.image_id, c.user_id, c.user_name AS comment_user_name, c.comment_headline, c.comment_text, c.comment_date
          FROM ".COMMENTS_TABLE." c
          LEFT JOIN ".IMAGES_TABLE." i ON (i.image_id = c.image_id) ".$add_where."
          ORDER BY c.comment_date DESC
          LIMIT $offset, $commentperpage";
Also, since no USER_TABLE included in the query this block of code is no needed:

Code: [Select]

    $additional_sql = "";
      $table_fields = $site_db->get_table_fields(USERS_TABLE);
      foreach ($additional_user_fields as $key => $val) {
        if (isset($HTTP_POST_VARS[$key]) && isset($table_fields[$key])) {
          $additional_sql .= ", $key = '".un_htmlspecialchars(trim($HTTP_POST_VARS[$key]))."'";
        }
      }

And now a little bug fix
this code

Code: [Select]

  if (isset($HTTP_GET_VARS['user_id']) and $HTTP_GET_VARS['user_id'] != ""){
    $add_where = "WHERE c.user_id IN (".$user_id.") AND i.cat_id NOT IN ($cat_id_sql)";
  }else{
    $add_where = "WHERE i.cat_id NOT IN ($cat_id_sql)";
  }should be placed below

Code: [Select]

  $cat_id_sql = get_auth_cat_sql("auth_viewcat", "NOTIN").", ".get_auth_cat_sql("auth_readcomment", "NOTIN").", ".get_auth_cat_sql("auth_viewimage", "NOTIN");Otherwise when you open comments page for a specific user, you will get wrong total comments number and pages count

[zoolmann]

S . U . P . E . R .

Thanks, its very nice MOD 

[mawenzi]

@ V@no

... thanks for your additional input for tuning of this MOD ...
... I have updated the MOD description ... now it is Version 1.1 ... 

mawenzi

[tradenet]

I've set this MOD up with 4images v1.7
However, I'm getting a:

Warning: Division by zero in /home/4images/comments_all.php on line 146

Warning: Division by zero in /home/4images/comments_all.php on line 151

When I access the page. Any ideas?

Nice MOD BTW.
Thanks

[TheOracle]

@tradenet:

Try this :

$ratio = $width / $height;
      if ($ratio > 1) {
        $new_width = $dimension;
        $new_height = floor(($dimension/$width) * $height);
      }else {
        $new_width = floor(($dimension/$height) * $width);
        $new_height = $dimension;
      }

replace with :

Code: [Select]


$ratio = $width / $height;
      if ($ratio > 1) {
        $new_width = $dimension;
        $new_height = floor(($dimension/$width) * $height);
      }else {
        $new_width = floor(($dimension/$height) * $width);
        $new_height = $dimension;
        $ratio = 0;
      }



[V@no]

Warning: Division by zero in /home/4images/comments_all.php on line 146

Warning: Division by zero in /home/4images/comments_all.php on line 151

Replace

Code: [Select]

      $width = $thumb_info[0];
      $height = $thumb_info[1];With:

Code: [Select]

      $width = ($thumb_info[0]) ? $thumb_info[0] : 400;
      $height = ($thumb_info[1]) ? $thumb_info[1] : 400;

Code: [Select]


$ratio = $width / $height;
 if ($ratio > 1) {
 $new_width = $dimension;
 $new_height = floor(($dimension/$width) * $height);
 }else {
 $new_width = floor(($dimension/$height) * $width);
 $new_height = $dimension;
 $ratio = 0;
 }



HUH? Would you be so kind an explain what the hell that supposed to change? Jeez...Stop embarrassing yourself...

[tradenet]

  TheOracle 

Thanks V@no. That worked.

[JensF]

Hi Detlef,

habe folgendes kleines Problem festgestellt

Wenn man als Admin nen Kommentar schreibt erscheint man in der Liste als Member.....Ist mir gerade so aufgefallen.

[Eschy5]

Ich habe den Hack bei www.verkehrsgigant.info auch eingebaut. Mir gefällt er ganz ganz, aber am Style habert´s noch etwas. Wie bekomme ich das richtig hin?

http://www.verkehrsgigant.info/comments_all.php

[mawenzi]

hallo Eschy5,
... das ist dann eigentlich "nur" html-coding ...
... hast du die comments_all.html entsprechend 2.Schritt aus deiner error.html erstellt ... ?
... ansonsten ... probier es nochmals ... ggf. hast etwas zu viel von den Tabellen weggelöscht ...
... sei vorsichtig mit den Table-Tags ... <table><tr><td> ... </td></tr></table> ...
... die Schriftfarbe von "head2" in style.css solltest du noch ändern ...

mawenzi

[Eschy5]

Ich hab´s nochmal probiert, war anscheinend mein Fehler. 
Aber der Tabellenkopf müsste eigentlich, wenn es den gleichen Style benutzt, hellblau sein. Ist er aber nicht, er ist dunkelblau.