4images Forum & Community

4images Issues / Ausgaben => Feedback & Suggestions => Topic started by: kai on March 02, 2006, 04:58:04 PM

Title: 4images 1.7.2 - Feedback
Post by: kai on March 02, 2006, 04:58:04 PM
Bitte nutzt diesen Thread für Feedback, Kommentare und Anregungen zum 4images 1.7.2 Release.
Für Bug Reports und troubleshooting bitte dieses (http://www.4homepages.de/forum/index.php?board=4.0) Forum nutzen.

Please use this thread for feedback and comments about the 4images 1.7.2 release.
For bug reporting and troubleshooting please use this (http://www.4homepages.de/forum/index.php?board=4.0) forum.
Title: Re: 4images 1.7.2 - Feedback
Post by: trez on March 02, 2006, 05:21:20 PM
so, sounds good, but the question everyone will ask:

Will the update cause problems with installed MODs for 1.7..1?

hoert sich gut an, allerdings eine frage die jeden user interessieren wird:

Wird es komplikationen mit installierten MODs fuer 1.7.1 geben?


Georgi
Title: Re: 4images 1.7.2 - Feedback
Post by: tatty on March 02, 2006, 05:55:36 PM
hia!
I've just updated my 1.7.1 version for 1.7.2
I followed the instructions on docs/Update.English.txt
The gallery is working, but I couldn't create any thumbnail and I couldn't see the images after checked and added.

Is there any of the fix bugs I shall use for this version too??  :D
Title: Re: 4images 1.7.2 - Feedback
Post by: IcEcReaM on March 02, 2006, 06:09:35 PM
Just one other question.

I want to upgrade but take overview only the changed parts of each php file,
by checking it with UltraEdit.

So can you give me a list of the the chenged templates files?

I took already yesterday a short look at it,
but didn't compare any files yet.

Title: Re: 4images 1.7.2 - Feedback
Post by: theresa_rose on March 02, 2006, 08:11:33 PM
Look in the changelog under the docs directory.  It shows the new files and the changed files.

Quote
Neue Dateien / New Files:
---------------------------------------
- admin/calendar.js
- admin/browserSniffer.js
- admin/images/arrow_back.gif
- admin/images/minus.gif
- admin/images/plus.gif
- admin/phpinfo.php

Geänderte Dateien / Changed Files:
---------------------------------------
- categories.php
- details.php
- download.php
- global.php
- index.php
- lightbox.php
- login.php
- logout.php
- member.php
- postcards.php
- register.php
- search.php
- top.php
- includes/auth.php
- includes/db_utils.php
- includes/email.php
- includes/functions.php
- includes/image_utils.php
- includes/template.php
- includes/zip.php
- admin/admin_functions.php
- admin/admin_global.php
- admin/backup.php
- admin/categories.php
- admin/cpstyle.css
- admin/comments.php
- admin/images.php
- admin/index.php
- admin/settings.php
- admin/templates.php
- admin/usergroups.php
- admin/users.php
- admin/validateimages.php

Geänderte Templates / Changed Templates:
---------------------------------------
- postcard_create.html
- postcard_preview.html
- bbcode.html
Title: Re: 4images 1.7.2 - Feedback
Post by: BartAfterDark on March 02, 2006, 08:26:41 PM
Why is there one called _functions.php ?
Title: Re: 4images 1.7.2 - Feedback
Post by: Jan on March 02, 2006, 09:37:40 PM
Opps  :oops: Removed it from the download file
Title: Re: 4images 1.7.2 - Feedback
Post by: egozent on March 02, 2006, 10:39:03 PM
Oh mann, jetzt hab ich grad das Skript über mehrere Wochen nach meinen Vorstellungen angepaßt,
nun erfahre ich, daß grad als ich fertig geworden bin, eine neue Version 1.7.2 rausgekommen ist.  :?
An sich ja toll, nur leider muß ich feststellen, daß ich sehr viele Dateien nochmal anpassen muß.
Ich hoffe, ich kann mich noch an alle Änderungen erinnern. War ne Mordsarbeit..
Title: Re: 4images 1.7.2 - Space between
Post by: fitterashes on March 03, 2006, 02:07:42 AM
I just installed 1.7.2, it went fine but with this new version there is a space between "categories" and "subcategories" if there isn't any description (see screenshot).
Any idea to fix that ?

Thanks
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 03, 2006, 02:37:46 AM
Hmmm...I'd try look if you used a default template...but when you are using custom made template how can anyone help you? check your templates first.

P.S. this is a feedback topic which supposed to be for oppinions on how do you like/dislike the new version and not about how to fix this or that problem...start a new topic for this metter if you wish.
Title: Re: 4images 1.7.2 - Feedback
Post by: honda2000 on March 03, 2006, 08:29:34 AM
ich muss egozent und sicher in kurzer zeit noch vielen anderen recht geben.

Ja, jeder ist bestrebt immer die "neueste Version" zu besitzen

Super-Arbeit der Programmierer, allerdings

1000 von Usern haben sich hier und da ein paar wenige oder auch ganz viele MODßs istalliert, die sind ALLE weg!

Dateien wie:
- categories.php
- details.php
- download.php
- global.php
- admin/admin_functions.php
- admin/admin_global.php
- admin/backup.php
- admin/categories.php
- admin/cpstyle.css
- admin/comments.php
- admin/images.php
- admin/index.php
- admin/settings.php

werden in der Regel von fast jedem User beim Einbau der MOD´s geändert!

ich weiss, etwas viel verlangt, aber gibt es nicht die Möglichkeit, uptade auf 1.7.2 so zu machen, wie man einen Mod einbaut??

search xxx
ad bevore
ad after
xxx
???
Title: Re: 4images 1.7.2 - Feedback
Post by: BartAfterDark on March 03, 2006, 12:12:45 PM
I got one problem with 1.7.2
The ICQ function does not work properly for me (or maybe a MOD destroyed it)
Look at image
Title: Re: 4images 1.7.2 - Feedback
Post by: TIMT on March 03, 2006, 12:31:40 PM
P.S. this is a feedback topic which supposed to be for oppinions on how do you like/dislike the new version and not about how to fix this or that problem...start a new topic for this metter if you wish.
Title: Re: 4images 1.7.2 - Feedback
Post by: egozent on March 03, 2006, 03:56:20 PM
Oh mann, jetzt hab ich grad das Skript über mehrere Wochen nach meinen Vorstellungen angepaßt,
nun erfahre ich, daß grad als ich fertig geworden bin, eine neue Version 1.7.2 rausgekommen ist.  :?
An sich ja toll, nur leider muß ich feststellen, daß ich sehr viele Dateien nochmal anpassen muß.
Ich hoffe, ich kann mich noch an alle Änderungen erinnern. War ne Mordsarbeit..
Puh, hab meine Galerie gerade auf 1.7.2. aktualisiert und es funktioniert bis jetzt alles ganz gut.
Es war doch nicht so schlimm, wie ich befürchtet hatte. Lediglich meine Clickstream-Geschichte war davon betroffen.
Aber das habe ich nun doch recht schnell wieder hinbekommen (dank Backup zum Vergleichen der Dateien).
Wie gesagt, bis jetzt schaut's gut aus und die Neuerungen im Admin-Bereich finde ich gut.  8)
Title: Re: 4images 1.7.2 - Feedback
Post by: egozent on March 03, 2006, 04:16:27 PM
Kann mir jemand sagen, was bei folgenden Dateien geändert wurde?
- postcard_create.html
- postcard_preview.html
- bbcode.html
Da ich das 7dana-Template verwende, zerreißt es beim Ersetzen der Dateien das Design.
Title: Re: 4images 1.7.2 - Feedback
Post by: fattymattybrewing on March 03, 2006, 07:01:55 PM
well the only file that the changelog has overlooked is the calendar.gif file is new too...

- admin/calendar.js
- admin/browserSniffer.js
- admin/images/arrow_back.gif
- admin/images/minus.gif
- admin/images/plus.gif
- admin/phpinfo.php

I replaced/loaded all the updated(changed) and new files but didn't see the calendar.gif file on the changelog and saw it missing on my control panel.

its there now...

Matt
Fatty Matty Brewing
http://www.fattymattybrewing.com
Title: Re: 4images 1.7.2 - Feedback
Post by: RoadDogg on March 03, 2006, 09:10:44 PM
ich muss egozent und sicher in kurzer zeit noch vielen anderen recht geben.
.....
ich weiss, etwas viel verlangt, aber gibt es nicht die Möglichkeit, uptade auf 1.7.2 so zu machen, wie man einen Mod einbaut??

search xxx
ad bevore
ad after
xxx
???

Für das wbb macht das zB immer ein user, der die alten mit den neuen Dateien vergleicht und ein ausführliches changelog online stellt. Wie oben beschrieben, muss man das mit einem textcomparetool machen, die Arbeit steht mit in ein paar Wochen auch bevor  :|
Title: Re: 4images 1.7.2 - Feedback
Post by: IcEcReaM on March 03, 2006, 09:47:24 PM
Nimm UltraEdit dann geht das relativ fix.
Bin gerade dabei meine Gallery upzudaten.
Title: Re: 4images 1.7.2 - Feedback
Post by: vanish on March 04, 2006, 12:01:20 AM
1..7.2
in sessions.php

you will see
Code: [Select]
if ($this->read_cookie_data("userpass") === $this->user_info['user_password'] && $this->user_info['user_level'] > USER_AWAITING) {

"===" is mistake?
Title: Re: 4images 1.7.2 - Feedback
Post by: obmob01 on March 04, 2006, 12:21:21 AM
1..7.2
in sessions.php

you will see
Code: [Select]
if ($this->read_cookie_data("userpass") === $this->user_info['user_password'] && $this->user_info['user_level'] > USER_AWAITING) {

"===" is mistake?
LOL i came for the same reason, how ironic  :P
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 04, 2006, 12:30:03 AM
from php.net (http://php.net/manual/en/language.expressions.php)
Quote
The language also supports a set of strict equivalence operators: === (equal to and same type) and !== (not equal to or not same type).
Title: Re: 4images 1.7.2 - Feedback
Post by: vanish on March 04, 2006, 12:47:00 AM
This code in functions.php
Code: [Select]
  static $trans;
if (!isset($trans)) {
  $trans = get_html_translation_table(HTML_ENTITIES);
unset($trans["'"]);
  unset($trans['"']);
  unset($trans['<']);
  unset($trans['>']);
}

  $text = strtr($text, $trans);
don't display cyrillic properly
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 04, 2006, 01:10:16 AM
more info needed...didnt display how, where, what did you see, etc ;)
Title: Re: 4images 1.7.2 - Feedback
Post by: vanish on March 04, 2006, 01:27:38 AM
да крякозябры одни... см. скиншот

Да и еще момент:
новая функция redirect существенно замедляет процесс пересортировки (перемещения вверх-вниз) категорий в админ-панели. Т.е. см. файл admin/categories.php, там в 1.7.2 поменялось например   $action = "modifycats"; на forward_to_modify($msg);.
Title: Re: 4images 1.7.2 - Feedback
Post by: Bugfixed on March 04, 2006, 11:16:43 AM
hello all.
I updated my gallery 1.7.1 up 1.7.2. after update charset problem  pls help me.
my page charset is iso-8859-9 >turkish
 :cry:
Title: Re: 4images 1.7.2 - Feedback
Post by: vanish on March 04, 2006, 11:40:52 AM
{ifno ...}{endifno ...} не работает, пришлось откатиться на процедуру от @Vano :(
Title: Re: 4images 1.7.2 - Feedback
Post by: egozent on March 04, 2006, 11:56:52 AM
Kann mir jemand sagen, was bei folgenden Dateien geändert wurde?
- postcard_create.html
- postcard_preview.html
- bbcode.html
Da ich das 7dana-Template verwende, zerreißt es beim Ersetzen der Dateien das Design.

Kann mir keiner helfen?  :(
Title: Re: 4images 1.7.2 - Feedback
Post by: kief24 on March 04, 2006, 12:45:06 PM
No bug fix for the session-id's problem in 1.7.1 ? ( search friendly url-mod --> session id doesn't go away in 1.7.1)

Title: Re: 4images 1.7.2 - Feedback
Post by: vanish on March 04, 2006, 01:29:49 PM
In admin/categories.php

Code: [Select]
$category .= get_category_dropdown_bits($cat_parent_id, 0, $cat_id);
must be

Code: [Select]
$category .= get_category_dropdown_bits($cat_parent_id);
Title: Re: 4images 1.7.2 - Feedback
Post by: djith on March 04, 2006, 02:36:56 PM
So the best solution to fix this problem in 1.7.1 is upgrading to 1.7.2 ?

Is there realy no way out to fix it in 1.7.1 ?

please, would save me a lot of sweat behind my screen !!
Title: Re: 4images 1.7.2 - Feedback
Post by: kai on March 04, 2006, 02:50:50 PM
So the best solution to fix this problem in 1.7.1 is upgrading to 1.7.2 ?

Is there realy no way out to fix it in 1.7.1 ?

All important fixes for can be found in the "Bug Fixes" section:
http://www.4homepages.de/forum/index.php?board=17.0


An update to 1.7.2 additionally includes minor important bugfixes and new features. Please have a look at the change log:
http://www.4homepages.de/forum/index.php?topic=11877.msg63240#msg63240
Title: Re: 4images 1.7.2 - Feedback
Post by: Nicole2212 on March 04, 2006, 03:48:00 PM
Huhu

Seiddem ich die neu version drauf habe kann ich keine bilder mehr hochladen.
Er sagt immer Die Datei hat ein ungültiges Format (jpg, image/jpg).
Bloss ich habe nichts an der einstellung geändert.

Was mach ich nun?

Lieben Gruß
Nicole

Title: Re: 4images 1.7.2 - Feedback
Post by: Fastian on March 04, 2006, 04:43:43 PM
Waoo... Great news.  :D

I just want to ask one thing.
How important this update is?

Is their any other security issue or some serious bug fix involve in it?  I mean other than the listed ones for 1.7.1?

I would love to update to 1.7.2 but I am over head busy at the moment so I just want to make sure that I can update after few weeks?

I have installed so many mods. Will all of them still be effective?
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 04, 2006, 04:51:43 PM
There is no known bugs fixes for 1.7.1 that were not included in v1.7.2.
v1.7.2 is more or less a bug fixes for v1.7.1 with a couple new features.

The down side of any PHP scripts is that when upgrading any installed mods will be gone (atleast the changes in the updated files will be gone).
Title: Re: 4images 1.7.2 - Feedback
Post by: IcEcReaM on March 04, 2006, 07:48:04 PM
For the Upload Problem with jpg Files,
you should edit your upload_definitions.php in includes folder:

Replace this:
Code: [Select]
$mime_type_match['jpg'] = array("image/jpeg", "image/pjpeg");
$mime_type_match['jpeg'] = array("image/jpeg", "image/pjpeg");
with this:
Code: [Select]
$mime_type_match['jpg'] = array("image/jpg", "image/jpeg", "image/pjpeg");
$mime_type_match['jpeg'] = array("image/jpg", "image/jpeg", "image/pjpeg");

P.S.:@admin, is there any reason why this were changed?
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 04, 2006, 08:07:33 PM
P.S.:@admin, is there any reason why this were changed?
Its never been changed, it simply never was there ;)
Normaly jpeg extension is being used and jpg is on systems where extension can be only 3 letters....(MSDOS)
Title: Re: 4images 1.7.2 - Feedback
Post by: IcEcReaM on March 04, 2006, 08:13:55 PM
It was there in 1.71 but in 1.72 it isn't there anymore.

If actually chcked an "fresh" version of 1.71
Title: Re: 4images 1.7.2 - Feedback
Post by: egozent on March 04, 2006, 09:04:04 PM
Kann mir jemand sagen, was bei folgenden Dateien geändert wurde?
- postcard_create.html
- postcard_preview.html
- bbcode.html
Da ich das 7dana-Template verwende, zerreißt es beim Ersetzen der Dateien das Design.

Kann mir keiner helfen?  :(
Echt keiner?  :(
Title: Re: 4images 1.7.2 - Feedback
Post by: djith on March 04, 2006, 10:35:00 PM
Digged up every session id related topic, integrated all changings recommanded to get rid of session id's. i'm using version 1.7.1
But still, a first time visitor get a session id..... also google and other search engines......

i see that version 1.7 doesn't have this problem.... where is the difference between 1.7 and 1.7.1 according session id's ?
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 05, 2006, 08:06:34 AM
All versions add sessionid on first visit, its not a problem its a feature, without that, visitors with blocked cookies will not be able fully use 4images based sites.
Title: Re: 4images 1.7.2 - Feedback
Post by: Fastian on March 05, 2006, 05:20:55 PM
Is their any database change involve between 1.7.1 & 1.7.2?

If I install V 1.7.2 to my PC (local server), Apply all the required modification (By comparing each file) that are necessary for the working of dozens of Mods that I have with 1.7.1 And then, just copy the local files to my web server.
Will this work???

I am just afraid of loosing any Mod functionally that I have right now.
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 05, 2006, 06:08:12 PM
Since any mods involved in php code changes, you WILL loose all your mods once you upgraded...:(
The database was not changed, so you will need "only" redo the steps that involved code changes.
Title: Re: 4images 1.7.2 - Feedback
Post by: nobby on March 05, 2006, 09:48:16 PM
Klasse, habe heute 1.7.2 installiert. Läuft hervorragend. Ich musste lediglich 2 Scripte Anpassen.
Und da ich einen eigenen Template-Ordner verwende musste ich hier nichts tun, alles läuft prima!  :D

Macht weiter so!!!   :mrgreen:

Gruß
Nobby
Title: Re: 4images 1.7.2 - Feedback
Post by: vanish on March 05, 2006, 11:09:11 PM
Why function format_url was changed? Now in user profile you can see "http://" when user haven't homepage.
Title: Re: 4images 1.7.2 - Feedback
Post by: egozent on March 06, 2006, 10:17:32 AM
Kann mir jemand sagen, was bei folgenden Dateien geändert wurde?
- postcard_create.html
- postcard_preview.html
- bbcode.html
Da ich das 7dana-Template verwende, zerreißt es beim Ersetzen der Dateien das Design.

Kann mir keiner helfen?  :(
Echt keiner?  :(
Schade.. :cry:
Title: Re: 4images 1.7.2 - Feedback
Post by: BartAfterDark on March 06, 2006, 05:43:36 PM
Why can't you just change them so they look like the design again?
It's really not that hard

Kann mir jemand sagen, was bei folgenden Dateien geändert wurde?
- postcard_create.html
- postcard_preview.html
- bbcode.html
Da ich das 7dana-Template verwende, zerreißt es beim Ersetzen der Dateien das Design.

Kann mir keiner helfen?  :(
Echt keiner?  :(
Schade.. :cry:
Title: Re: 4images 1.7.2 - Feedback
Post by: colorssky on March 07, 2006, 10:53:52 AM
can I change only the new files?
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 07, 2006, 02:28:16 PM
mmm....there are not many "old" files anyways...
Title: Re: 4images 1.7.2 - Feedback
Post by: colorssky on March 07, 2006, 03:01:01 PM
ok what about te template files, shall I change it as well?
I worked a lot on that!
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 07, 2006, 03:04:31 PM
Just look in the docs/Changelog.txt
It will give you an idea which files were changed.
Title: Re: 4images 1.7.2 - Feedback
Post by: RED_LINE on March 07, 2006, 07:55:23 PM
Hello

it's great job and i hope to get some answer for my problem

i tried to upgrade and all things it is ok but when i upload the new global.php file i can't open my gallery script ( i use mod_rewrite ) .. when i reupload the old file evrythings is ok !!

any answers?

That's All

Best Regards
Title: Re: 4images 1.7.2 - Feedback
Post by: RED_LINE on March 07, 2006, 08:00:13 PM
Hello

it's great job and i hope to get some answer for my problem

i tried to upgrade and all things it is ok but when i upload the new global.php file i can't open my gallery script ( i use mod_rewrite ) .. when i reupload the old file evrythings is ok !!

any answers?

That's All


sorry .. the problem sloved :)

the problem was that no English Language folder

Thanx
Best Regards
Title: Re: 4images 1.7.2 - Feedback
Post by: Moustacy on March 08, 2006, 01:22:32 PM
Ever since I upgraded picture information resets.

Scenario.

I'm about to upload a picture. I type in the title description and keywords and upload it.

I then press the back button so I can put a different picture and just change the number in the title keeping the same description and keywords but it resets whenever I try to go back so uploading a picture in the same category I have to retype the description and keywords over and over for each picture.

Is there a way to fix this? Does it have to do with sessions?
Title: BUG in 4images 1.7.2
Post by: vanish on March 13, 2006, 03:33:38 PM
Don't store selected category order when you want to update category.
To resolve this problem in admin/categories.php

change this code:
Code: [Select]
if ($action == "updatecat") {
  $error = array();
  $cat_id = (isset($HTTP_POST_VARS['cat_id'])) ? intval($HTTP_POST_VARS['cat_id']) : intval($HTTP_GET_VARS['cat_id']);

  $cat_parent_id = intval($HTTP_POST_VARS['cat_parent_id']);
  $cat_name = un_htmlspecialchars(trim($HTTP_POST_VARS['cat_name']));
  $cat_description = un_htmlspecialchars(trim($HTTP_POST_VARS['cat_description']));
  $cat_hits = intval(trim($HTTP_POST_VARS['cat_hits']));

  $auth_viewcat = $HTTP_POST_VARS['auth_viewcat'];
  $auth_viewimage = $HTTP_POST_VARS['auth_viewimage'];
  $auth_download = $HTTP_POST_VARS['auth_download'];
  $auth_upload = $HTTP_POST_VARS['auth_upload'];
  $auth_directupload = $HTTP_POST_VARS['auth_directupload'];
  $auth_vote = $HTTP_POST_VARS['auth_vote'];
  $auth_sendpostcard = $HTTP_POST_VARS['auth_sendpostcard'];
  $auth_readcomment = $HTTP_POST_VARS['auth_readcomment'];
  $auth_postcomment = $HTTP_POST_VARS['auth_postcomment'];
  $subcats = (isset($HTTP_POST_VARS['subcats']) && $HTTP_POST_VARS['subcats']) ? 1 : 0;

  $subcat_ids = array();
  get_subcategories_id($cat_id);

  if ($cat_parent_id == $cat_id || in_array($cat_parent_id, $subcat_ids)) {
    $msg .= sprintf("<span class=\"marktext\">%s</span><br />", $lang['parent_cat_error']);
    $error['cat_parent_id'] = 1;
  }
  if ($cat_name == "") {
    $error['cat_name'] = 1;
  }

  if (empty($error)) {
    $sql = "UPDATE ".CATEGORIES_TABLE."
            SET cat_name = '$cat_name', cat_description = '$cat_description', cat_parent_id = $cat_parent_id, cat_hits = $cat_hits, auth_viewcat = $auth_viewcat, auth_viewimage = $auth_viewimage, auth_download = $auth_download, auth_upload = $auth_upload, auth_directupload = $auth_directupload, auth_vote = $auth_vote, auth_sendpostcard = $auth_sendpostcard, auth_readcomment = $auth_readcomment, auth_postcomment = $auth_postcomment
            WHERE cat_id = $cat_id";
    $result = $site_db->query($sql);

    if ($subcats) {
      function get_subcategories_id($cat_id = 0)
      {
        global $subcat_ids, $cat_parent_cache;
     
        if (!isset($cat_parent_cache[$cat_id]))
        {
          return false;
        }
        foreach ($cat_parent_cache[$cat_id] as $key => $val)
        {
          $subcat_ids[] = $val;
          get_subcategories_id($val);
        }
        return $subcat_ids;
      }
      $subcat_ids = array();
      $subcat_ids = get_subcategories_id($cat_id);
      if (!empty($subcat_ids))
      {
        $sql = "UPDATE ".CATEGORIES_TABLE."
                SET auth_viewcat = $auth_viewcat, auth_viewimage = $auth_viewimage, auth_download = $auth_download, auth_upload = $auth_upload, auth_directupload = $auth_directupload, auth_vote = $auth_vote, auth_sendpostcard = $auth_sendpostcard, auth_readcomment = $auth_readcomment, auth_postcomment = $auth_postcomment
                WHERE cat_id IN (".implode($subcat_ids, ",").")";
        $result = $site_db->query($sql);
      }
    }

    $msg = ($result) ? $lang['cat_edit_success'] : $lang['cat_edit_error'];
    $action = "modifycats";
  }
  else {
    $msg .= sprintf("<span class=\"marktext\">%s</span>", $lang['lostfield_error']);
    $action = "editcat";
  }
}

to this:
Code: [Select]
if ($action == "updatecat") {
  $error = array();
  $cat_id = (isset($HTTP_POST_VARS['cat_id'])) ? intval($HTTP_POST_VARS['cat_id']) : intval($HTTP_GET_VARS['cat_id']);

  $cat_parent_id = intval($HTTP_POST_VARS['cat_parent_id']);
  $cat_name = un_htmlspecialchars(trim($HTTP_POST_VARS['cat_name']));
  $cat_description = un_htmlspecialchars(trim($HTTP_POST_VARS['cat_description']));
  $cat_hits = intval(trim($HTTP_POST_VARS['cat_hits']));
  $cat_order = (isset($HTTP_POST_VARS['cat_order'])) ? intval($HTTP_POST_VARS['cat_order']) : 0;

  $auth_viewcat = $HTTP_POST_VARS['auth_viewcat'];
  $auth_viewimage = $HTTP_POST_VARS['auth_viewimage'];
  $auth_download = $HTTP_POST_VARS['auth_download'];
  $auth_upload = $HTTP_POST_VARS['auth_upload'];
  $auth_directupload = $HTTP_POST_VARS['auth_directupload'];
  $auth_vote = $HTTP_POST_VARS['auth_vote'];
  $auth_sendpostcard = $HTTP_POST_VARS['auth_sendpostcard'];
  $auth_readcomment = $HTTP_POST_VARS['auth_readcomment'];
  $auth_postcomment = $HTTP_POST_VARS['auth_postcomment'];
  $subcats = (isset($HTTP_POST_VARS['subcats']) && $HTTP_POST_VARS['subcats']) ? 1 : 0;

  $subcat_ids = array();
  get_subcategories_id($cat_id);

  if ($cat_parent_id == $cat_id || in_array($cat_parent_id, $subcat_ids)) {
    $msg .= sprintf("<span class=\"marktext\">%s</span><br />", $lang['parent_cat_error']);
    $error['cat_parent_id'] = 1;
  }
  if ($cat_name == "") {
    $error['cat_name'] = 1;
  }

  if (empty($error)) {
    if (!$cat_order) {
      $sql = "SELECT cat_order
              FROM ".CATEGORIES_TABLE."
              WHERE cat_parent_id = $cat_parent_id
              ORDER BY cat_order DESC
              LIMIT 1";
      $catorder = $site_db->query_firstrow($sql);
      $cat_order = $catorder['cat_order'] + 10;
      $do_updat_cat_order = 0;
    }
    else {
      $do_updat_cat_order = 1;
    }
    $sql = "UPDATE ".CATEGORIES_TABLE."
            SET cat_name = '$cat_name', cat_order = '$cat_order', cat_description = '$cat_description', cat_parent_id = $cat_parent_id, cat_hits = $cat_hits, auth_viewcat = $auth_viewcat, auth_viewimage = $auth_viewimage, auth_download = $auth_download, auth_upload = $auth_upload, auth_directupload = $auth_directupload, auth_vote = $auth_vote, auth_sendpostcard = $auth_sendpostcard, auth_readcomment = $auth_readcomment, auth_postcomment = $auth_postcomment
            WHERE cat_id = $cat_id";
    $result = $site_db->query($sql);

    if ($do_updat_cat_order) {
        update_cat_order($cat_parent_id);
    }
    if ($subcats) {
      function get_subcategories_id($cat_id = 0)
      {
        global $subcat_ids, $cat_parent_cache;
     
        if (!isset($cat_parent_cache[$cat_id]))
        {
          return false;
        }
        foreach ($cat_parent_cache[$cat_id] as $key => $val)
        {
          $subcat_ids[] = $val;
          get_subcategories_id($val);
        }
        return $subcat_ids;
      }
      $subcat_ids = array();
      $subcat_ids = get_subcategories_id($cat_id);
      if (!empty($subcat_ids))
      {
        $sql = "UPDATE ".CATEGORIES_TABLE."
                SET auth_viewcat = $auth_viewcat, auth_viewimage = $auth_viewimage, auth_download = $auth_download, auth_upload = $auth_upload, auth_directupload = $auth_directupload, auth_vote = $auth_vote, auth_sendpostcard = $auth_sendpostcard, auth_readcomment = $auth_readcomment, auth_postcomment = $auth_postcomment
                WHERE cat_id IN (".implode($subcat_ids, ",").")";
        $result = $site_db->query($sql);
      }
    }

    $msg = ($result) ? $lang['cat_edit_success'] : $lang['cat_edit_error'];
    $action = "modifycats";
  }
  else {
    $msg .= sprintf("<span class=\"marktext\">%s</span>", $lang['lostfield_error']);
    $action = "editcat";
  }
}
Title: Re: 4images 1.7.2 - Feedback
Post by: Moustacy on March 18, 2006, 06:59:04 AM
Is there ANYONE that can answer my question?
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on March 18, 2006, 02:33:59 PM
clear your browser's cache, looks like your browser does not cache pages anymore...its most probably related to your computer and fact that it start happening after the upgrade is pure coincidental...
Title: Re: 4images 1.7.2 - Feedback
Post by: Moustacy on March 25, 2006, 02:12:34 PM
I've cleared the cache, restarted EVERYTHING this is a new computer. Ever since I upgraded it's happened. I was uploading pictures before I upgraded and it was working fine. That's why I was asking if there was something new in one of the files making the gallery do that.
Title: Re: 4images 1.7.2 - Feedback
Post by: MIKS on March 26, 2006, 03:02:03 PM
How to update gallery, if i have installed mods. I don't won't do this again.  :?: Do anyone have update guide in text, like PhpBB (what file, what to update).  :?:

P.S.
Sory for my bad english  :oops:
Title: Re: 4images 1.7.2 - Feedback
Post by: Kevin Chi on March 29, 2006, 04:26:56 PM
4Images 1.72 really is an extremely good design, not only has solved my many problems, also lets me simultaneously study the more thorough database utilization, extremely thank the author attentively and diligently.  :D
Title: Re: 4images 1.7.2 - Feedback
Post by: waleed on April 02, 2006, 02:21:01 AM
How to update gallery, if i have installed mods. I don't won't do this again.  :?: Do anyone have update guide in text, like PhpBB (what file, what to update).  :?:

P.S.
Sory for my bad english  :oops:

same here  :cry:
Title: Re: 4images 1.7.2 - Feedback
Post by: dabri on April 02, 2006, 03:34:15 PM
Ich will nun endlich mal meine vorhandene Gallery updaten, bin immer noch auf 1.7.0.

Meine Frage, kann mir Jemand sagen, ob sich bei irgendeiner Tabelle in der Datenbank die Struktur geändert hat bei einem Sprung von 1.7.0 auf 1.7.2?

Danke & Gruß

Daniel
Title: Re: 4images 1.7.2 - Feedback
Post by: waleed on April 03, 2006, 02:10:35 AM
which file excatly i have to run if i want to upgrade from 1.7 to 1.7.2 ?
or just replace the files? i read the docs but i didnt understand plz.
Title: Re: 4images 1.7.2 - Feedback
Post by: dabri on April 03, 2006, 06:56:00 PM
which file excatly i have to run if i want to upgrade from 1.7 to 1.7.2 ?
or just replace the files? i read the docs but i didnt understand plz.

Code: [Select]
       Update 1.7 -> 1.7.2
       ...............................
       - No update-script required

Just replace the files.

Daniel
Title: Re: 4images 1.7.2 - Feedback
Post by: waleed on April 05, 2006, 01:47:10 AM
i have problem using my old template ..
i was using ver 1.7 + 7dana template with some Mods i re-installed them again

now i get error when i try to use the same template
but when i use the default template the gallery works fine

i read the changelog and replaced .html files but still i get this error
Parse error: parse error, unexpected $ in /home/--------/public_html/------/includes/template.php(101) : eval()'d code on line 259  :(

any idea plz ?
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on April 05, 2006, 02:52:40 AM
Please reply to the template topic you are refering to. This topic is not for asking support!
Title: Re: 4images 1.7.2 - Feedback
Post by: Lorcan on April 25, 2006, 02:18:04 PM
Hm, hab schon die Suchfunktion rauf und runter durchgeorgelt aber offensichtlich ist folgendes Sicherheitsproblem noch nicht bis hierher durchgedrungen:

Quote
Description:
Qex has discovered a vulnerability in 4images, which can be exploited by malicious people to conduct script insertion attacks.

Input passed to the "user_name" parameter in "register.php" isn't properly sanitised before being used. This can be exploited to inject arbitrary HTML and script code, which will be executed in a user's browser session in context of an affected site when the malicious user data is viewed.

The vulnerability has been confirmed in version 1.7.2 and has also been reported in version 1.7. Other versions may also be affected.

Quelle: http://secunia.com/advisories/19745/

Und nun die blöde Frage der Woche: Should I be concerned ? ... oder ist das mit meinem gerade eben frisch gezogenen Update auf 1.7.2 bereits schon mitgepatcht worden ?

Gruß,
  Lorcan
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on April 25, 2006, 02:43:03 PM
This has been fixed in current download package, yet, we'll post a security fix for those who downloaded v1.7.2 prior yesterday, as soon as possible
Thank you for reporting!
Title: Re: 4images 1.7.2 - Feedback
Post by: Jan on April 25, 2006, 02:59:02 PM
Quick solution:

Download the zip from download page (http://www.4homepages.de/4images/download.php) and replace your existing "global.php" with the one from the zip.
Title: Re: 4images 1.7.2 - Feedback
Post by: IWS_steffen on May 02, 2006, 05:54:28 AM
Danke

Klasse gemacht. Die neue Version 1.7.2 läuft super stabil. Mit etwas mehr MOD wäre es natürlich noch besser :D

Gruß Steffen

Title: Re: 4images 1.7.2 - Feedback
Post by: rustynet on May 27, 2006, 11:42:48 PM
Ich versuche immer so wenig Modifizierungen wie möglich zu installieren.
4images ist ein sehr gutes Skript, ich brauche eigentlich fast keine MOD's mehr.

Ein Update zu 1.7.2 hat bei mir nur ca. 15 min. gedauert, so leicht ist es.  8)
Das Update hat sich auf jedenfall gelohnt, 1.7.2 läuft super stabil, die Neuerungen im Admin Bereich finde ich auch gut.

Klasse gemacht, vielen dank !!

Gruß,
rusty
Title: Re: 4images 1.7.2 - Feedback
Post by: Riccardo on July 08, 2006, 03:35:43 PM
there were things to change for teh integration php thing when u upgrade from 1.7 to 1.7.2 do u have to apply the same changes again to the 1.7.2 files?

and do i need to change any template files if i just upgrad from 1.7 to 1.7.2?
Title: Re: 4images 1.7.2 - Feedback
Post by: V@no on July 08, 2006, 08:18:22 PM
upgrading any scripts means replacing the files. If you did changes in these files before the upgrade, its obvious that the changes will be lost and you'll have to do them again.